Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbbGITIx (ORCPT ); Thu, 9 Jul 2015 15:08:53 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48232 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbbGITIq (ORCPT ); Thu, 9 Jul 2015 15:08:46 -0400 Date: Thu, 9 Jul 2015 15:07:33 -0400 From: Konrad Rzeszutek Wilk To: Jiang Liu Cc: Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Grant Likely , Marc Zyngier , Stuart Yoder , Yijing Wang , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Tony Luck , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org Subject: Re: [RFC Patch V1 05/12] x86, PCI: Use for_pci_msi_entry() to access MSI device list Message-ID: <20150709190733.GE21016@l.oracle.com> References: <1436428847-8886-1-git-send-email-jiang.liu@linux.intel.com> <1436428847-8886-6-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436428847-8886-6-git-send-email-jiang.liu@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2275 Lines: 59 On Thu, Jul 09, 2015 at 04:00:40PM +0800, Jiang Liu wrote: > Use accessor for_pci_msi_entry() to access MSI device list, so we could > easily move msi_list from struct pci_dev into struct device later. > > Signed-off-by: Jiang Liu Looks pretty simple. Acked- by: Konrad Rzeszutek Wilk > --- > arch/x86/pci/xen.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c > index d22f4b5bbc04..ff31ab464213 100644 > --- a/arch/x86/pci/xen.c > +++ b/arch/x86/pci/xen.c > @@ -179,7 +179,7 @@ static int xen_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > if (ret) > goto error; > i = 0; > - list_for_each_entry(msidesc, &dev->msi_list, list) { > + for_each_pci_msi_entry(msidesc, dev) { > irq = xen_bind_pirq_msi_to_irq(dev, msidesc, v[i], > (type == PCI_CAP_ID_MSI) ? nvec : 1, > (type == PCI_CAP_ID_MSIX) ? > @@ -230,7 +230,7 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > if (type == PCI_CAP_ID_MSI && nvec > 1) > return 1; > > - list_for_each_entry(msidesc, &dev->msi_list, list) { > + for_each_pci_msi_entry(msidesc, dev) { > __pci_read_msi_msg(msidesc, &msg); > pirq = MSI_ADDR_EXT_DEST_ID(msg.address_hi) | > ((msg.address_lo >> MSI_ADDR_DEST_ID_SHIFT) & 0xff); > @@ -274,7 +274,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > int ret = 0; > struct msi_desc *msidesc; > > - list_for_each_entry(msidesc, &dev->msi_list, list) { > + for_each_pci_msi_entry(msidesc, dev) { > struct physdev_map_pirq map_irq; > domid_t domid; > > @@ -386,7 +386,7 @@ static void xen_teardown_msi_irqs(struct pci_dev *dev) > { > struct msi_desc *msidesc; > > - msidesc = list_entry(dev->msi_list.next, struct msi_desc, list); > + msidesc = first_pci_msi_entry(dev); > if (msidesc->msi_attrib.is_msix) > xen_pci_frontend_disable_msix(dev); > else > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/