Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753749AbbGIT5p (ORCPT ); Thu, 9 Jul 2015 15:57:45 -0400 Received: from casper.infradead.org ([85.118.1.10]:36180 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753203AbbGIT5n (ORCPT ); Thu, 9 Jul 2015 15:57:43 -0400 Date: Thu, 9 Jul 2015 21:57:37 +0200 From: Peter Zijlstra To: Arend van Spriel Cc: Vineet Gupta , Ingo Molnar , Arnd Bergmann , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Brett Rudley , "Franky (Zhenhui) Lin" , Hante Meuleman , Kalle Valo , Pieter-Paul Giesberts , Daniel Kim , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org Subject: Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive Message-ID: <20150709195737.GA26965@worktop.ger.corp.intel.com> References: <1436429599-10762-1-git-send-email-vgupta@synopsys.com> <1436429599-10762-3-git-send-email-vgupta@synopsys.com> <559EBC91.2070600@broadcom.com> <559EBDF4.7030808@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559EBDF4.7030808@broadcom.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 16 On Thu, Jul 09, 2015 at 08:31:16PM +0200, Arend van Spriel wrote: > >There is or there was? If there is now I am fine with this patch, but if > >it already was there the author might have had a reason for adding a > >local function and I would like to hear that reason. > > Nevermind. Just noticed you are proposing the generic implementation in this > series. Currently on vacation and want to discuss with Hante about this > change. No there is one in linux/atomic.h, he just renamed the #ifdef guard and provided a 'sane' implementation for his arch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/