Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753620AbbGIUJa (ORCPT ); Thu, 9 Jul 2015 16:09:30 -0400 Received: from sauhun.de ([89.238.76.85]:49307 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752089AbbGIUJX (ORCPT ); Thu, 9 Jul 2015 16:09:23 -0400 Date: Thu, 9 Jul 2015 22:09:13 +0200 From: Wolfram Sang To: Anurag Kumar Vulisha Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, punnaia@xilinx.com, harinik@xilinx.com, anirudh@xilinx.com, svemula@xilinx.com, Anurag Kumar Vulisha Subject: Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC Message-ID: <20150709200913.GL4744@katana> References: <1434644382-11905-1-git-send-email-anuragku@xilinx.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Jbyekxk18hnEXT0m" Content-Disposition: inline In-Reply-To: <1434644382-11905-1-git-send-email-anuragku@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 51 --Jbyekxk18hnEXT0m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, thanks for the submission! > +#define CDNS_I2C_BROKEN_HOLD_BIT 0x00000001 BIT(0) maybe? > +static const struct cdns_platform_data r1p10_i2c_def = { > + .quirks = CDNS_I2C_BROKEN_HOLD_BIT, }; Closing '}' should be on seperate line. And what Mark said. Other than that, looks okay I'd say. --Jbyekxk18hnEXT0m Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVntTpAAoJEBQN5MwUoCm2/FwP/1PfMFQP111mBlAJMjVt5zw1 8qPfXCnf+yjMV1JhSmNtoD+Iy3FvVKHoJeISRYG1oJtx/NVfcocwWOQc63uofnJN e4WasP7C1Moww2hE6Mm9Oe/XW+EIWug4cbwTA79AtzCwZcgQEBoKpa6LlhVVJq+E 4PEJcAeXE9+exdrSZL8TlhlKbShlhRlK8vIjMIDbJBeIvy2hDlqmf345LBK3OYKk ZjuDwBeNm0hECb3vuvipEWNGawPY6nctDpTgm58lHSRN8kq1lLcu3w6e+CFtHYmI lE3vWxuW3j7NDk3uwxvj7sMcTs5ZmcZiK/R/BE2bLWVnsQ83eqcJaIM08rpRY3uN RvFmacJ/ThVdBuExZy+z0JEnP3nSqHqn42ePFtvzuzFKpYlIApvjAnn+g8hMP0rM gxxKEv+Kkg8D/aIEmclvx4LP4UAl5A+C4qOE1MK5sgQ950U59i/53Y+B94HQlRtY 8dDIId7t4aXDKEIvsudkXUQwqfNFiBWOeGeUVgV+l6kmJoFFwScmPYGENRhtvtA1 KV18UaT2LDqntdDF2La7J/9eNUXEyvRSQAFEm8oIJt+DFUrFQbkCXAn0rytn0YFI 7zM44iCVbrR9SfY326AJVzCXbaH+ReAD0HB5FYEc5w24GJTHcPMnyFmehqHeS/Q3 XZ/FM6PLzlkRla+oaYOf =sEKs -----END PGP SIGNATURE----- --Jbyekxk18hnEXT0m-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/