Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753934AbbGIUTX (ORCPT ); Thu, 9 Jul 2015 16:19:23 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:37845 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753123AbbGIUTP (ORCPT ); Thu, 9 Jul 2015 16:19:15 -0400 Message-ID: <1436473148.20619.116.camel@tiscali.nl> Subject: Re: [PATCH v2] coresight: replicator: Use module_platform_driver From: Paul Bolle To: Vaishali Thakkar Cc: Mathieu Poirier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 09 Jul 2015 22:19:08 +0200 In-Reply-To: <20150709195944.GA4470@vaishali-Ideapad-Z570> References: <20150709195944.GA4470@vaishali-Ideapad-Z570> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 34 On vr, 2015-07-10 at 01:29 +0530, Vaishali Thakkar wrote: > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > -static int __init replicator_init(void) > -{ > - return platform_driver_register(&replicator_driver); > -} > -module_init(replicator_init); > - > -static void __exit replicator_exit(void) > -{ > - platform_driver_unregister(&replicator_driver); > -} > -module_exit(replicator_exit); > +module_platform_driver(replicator_driver); coresight-replicator.o is built if CONFIG_CORESIGHT_LINKS_AND_SINKS is defined. CORESIGHT_LINKS_AND_SINKS is a bool symbol. It depends on CORESIGHT, which is also a bool symbol. CORESIGHT is a top level symbol, available on arm and arm64. I think coresight-replicator.o can only be built-in. So I suggest to use builtin_platform_driver() instead. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/