Subject: Re: [PATCH 2/2] mvneta: use inband status only when link type is
 "auto"
To: Florian Fainelli <f.fainelli@gmail.com>
References: <559EB0A4.5080101@list.ru> <559EB22E.7070607@list.ru>
 <559EBAFE.6040705@gmail.com>
Cc: Linux kernel <linux-kernel@vger.kernel.org>,
        Sebastien Rannou <mxs@sbrk.org>, Arnaud Ebalard <arno@natisbad.org>,
        Stas Sergeev <stsp@users.sourceforge.net>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        netdev <netdev@vger.kernel.org>, stable@vger.kernel.org
From: Stas Sergeev <stsp@list.ru>
Message-ID: <559ED8F1.7050609@list.ru>
Date: Thu, 9 Jul 2015 23:26:25 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <559EBAFE.6040705@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1044
Lines: 24

09.07.2015 21:18, Florian Fainelli пишет:
> On 09/07/15 10:41, Stas Sergeev wrote:
>> The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state
>> signaling") implemented the link parameters auto-negotiation unconditionally.
>> Unfortunately it appears that some HW that implements SGMII protocol,
>> doesn't generate the inband status, so it is not possible to auto-negotiate
>> anything with such HW.
> What is the purpose of using the in-band status in the first place if
> you end-up having to specify a 'fixed-link' property which contains most
> of the link parameters: speed, duplex etc...?
You don't have to.
My config from today is as simple as:

fixed-link {
   link = "auto";
};

and that's all.
Without my today's patch, only 'speed' is a mandatory - not too much.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/