Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127AbbGIUwO (ORCPT ); Thu, 9 Jul 2015 16:52:14 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56706 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbbGIUwG (ORCPT ); Thu, 9 Jul 2015 16:52:06 -0400 Date: Thu, 9 Jul 2015 13:52:03 -0700 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Alex Hung , Corentin Chary , "platform-driver-x86@vger.kernel.org" , acpi4asus-user@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8 Message-ID: <20150709205203.GD111846@vmdeb7> References: <20150629122953.GF16230@pali> <20150630085814.GE27720@pali> <20150701114849.GE17577@pali> <20150703072523.GB1841@pali> <20150706224328.GB111639@vmdeb7> <20150707142518.GI12087@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150707142518.GI12087@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2492 Lines: 57 On Tue, Jul 07, 2015 at 04:25:18PM +0200, Pali Roh?r wrote: > On Monday 06 July 2015 15:43:28 Darren Hart wrote: > > On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote: > > > ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and > > > HP are doing it. It is just ASUS who decides LED should be controlled > > > by software unlike HP whose LED is driven by hardware pins on mini > > > card. > > > > Alex, please refrain from top posting on Linux kernel mailing lists, it breaks > > the established practice the readers are setup for. > > > > Regarding the ATK4001 device, it did sound like it did more than control the > > radios and the associcated LED. If that is all it does, then asus-rbtn is fine. > > If it does something beyond that, we need understand what that is, as a more > > platform-centric name would be more appropriate. > > > > Thanks, > > Yes, I understand too that ATK4001 device has more functions as one for > LED control. And in this case it is not good to use name from one > specific functionality. > > And about name: > > I chose name rbtn for dell driver because ACPI device in DSDT table is > named RBTN and acpi id is DELRBTN. > > I think that acpi-rbtn.c (radio button) is not ideal name for driver > which at SW level controls LED device associated with wireless devices. > > I would rather follow acpi device name, but in this case ATK4001 is even > worse name which does not say anything... > > Maybe better name could be asus-wireless? Still I do not have any good > name, so choose something... I suggested rbtn to try and start showing some kind of consistency in the directory - however, it's no better than many of the other existing options, including -rfkill -wireless -laptop, etc. Speaking of -laptop, the asus-laptop driver supports ATK0100 and ATK0101. This ATK4001 device appears to perform the same type of features. The question is whether or not it can be reasonably incorporated into the existing asus-laptop driver or not. (I intended to do that review myself, but I haven't found the time in 48 hours, so I'm just going to send this out and ask that Alex have a look and provide his thoughts on asus-laptop) -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/