Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754549AbbGIVEP (ORCPT ); Thu, 9 Jul 2015 17:04:15 -0400 Received: from mail-bn1on0075.outbound.protection.outlook.com ([157.56.110.75]:2239 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754281AbbGIVED (ORCPT ); Thu, 9 Jul 2015 17:04:03 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Date: Thu, 9 Jul 2015 14:03:58 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Krzysztof Kozlowski CC: Anirudha Sarangi , John Linn , Michal Simek , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check Message-ID: <20150709210358.GG3129@xsjsorenbubuntu> References: <1436448080-24775-1-git-send-email-k.kozlowski.k@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1436448080-24775-1-git-send-email-k.kozlowski.k@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21666.003 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD038;1:C1YHlKeML93GNIJYWs5399xFACwC7lS1cxrW3ybKyGzUJv8tBV9/ffniga7lvfioJxHDHMOfz53Y8AbHm0WNe2SsQc2szNSVumOSFX+cVeawrn1zMDTokbkylFdA8TTgFfCB4Z8hCkKAAkOqgkkMwOloUhbpmgzrSyipCitjqdFpxbAR55i0Fmroqx28nGEG5JOOh7T0hEDPI1IM3wdkJ6qLCO3W78QGyZYNZ3nZgBmPTCMH7zm0eO9m2NKhwfZ3erHuixIssDWyaYlMN32CIwEoTXcYL4OXKfGoOVSiXXVHNnuW2akSNCs2XdRxoPUd X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(51704005)(377424004)(199003)(189002)(77096005)(54356999)(63266004)(77156002)(57986006)(36386004)(5001960100002)(62966003)(110136002)(33716001)(47776003)(33656002)(76176999)(46102003)(4001350100001)(85202003)(76506005)(106466001)(19580395003)(50466002)(19580405001)(87936001)(6806004)(50986999)(189998001)(23676002)(92566002)(85182001)(2950100001)(86362001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB024;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB024;2:SqPqqtz6vicfWL/WNz8CqFWAwVBhRgJkqzu+i+yFp3cV4jTOC99EXmMDq028R79N;3:ZLtJM8r5pb919rUI+St397NNl9jAqR9Z/KOiQTxGZNwqoS1o1bdmqCo0m4fbuw+L/EjLktIb4165L7wgtPoPd3+lwR4S3Y7GtfUMIvcp+IJwboBkmB+FKZFMnF3REKtF7UNgwrJx9b1h/o+dQyt2L9E6Z7PLxU6fJ5+Evuf7nT22a/VCe866+5Pt9Ni/AeqTEF1SkU2XIk/A+6m6bab+XUrJCF5gQ0Hk5O3VC2csX4Z6jDquJPzWeCCz5rdYPUKg;25:x6nKAkCWDVujfpW1iTbAeM63MPpgDpvxM784MNdWa4YAUgx6O7/7eh3k4fh4iTbwdVXmZlLFJ+gubxkk7JQciREuCY+DzKH/ZvhrthVpoORr+LLlDuHZbe5Ti2UuM35CnE9yTA2z4jJmTpmNMtKVb91pY4IxOlGMgESgsGhpVmVcQwS7KaMC2FaM2mufXQbYseY99iallW5rrv1n2dSFznpzzUcuk0sqNfXszqrkJWfY/BCV5KBzTF43Nd8I4OwU X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB024; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB024;20:L1CGPYqXQSViaStmPNPb8hv4fDkCk/qu4Da+v0YY/ZM/hkXo/47tAMVzxBcuB0Wr0n5M6uCGX/YHp3cWo4c6vNOngyR++9glag70BCOp5Kjg6ngHurJX0B/j7ypaOt3EovhGU5/uyPAomiNvD3Sbi8t3bSKm0UODU40V+KCFkvRn2E0d3FUvDr9MGy5Qw1Nx49t41MRVmwByIn74HIQ2krlmpS2hAQrbfnCjfHzLTQwQGKonJFcozwEfgv3cYdteb3UKRj/f8jipWo4SBajGLKUggDMHOVDYqg/kN0/Qbepkcg4EBXV2ydtF8ZsHKHoExKizapnEi6DKNrFKminOCjTG4gRpGT3E7z93mfON5xiRSmgZgsKQ+pLqqpJFjaQhsmtfqUMd6L0NvLRIAD+3FFUGCje2dN6lYKJ+IVe+spir294gKf8PTT5kUxM+0yeKF5Di32j0OEaiB+o8oesHhh7IPNn/YlWgIfazCYoWi22PpzDCGnpXWvO0MpaZoS+9;4:C5kVC+UfXLyJrtqN8AlAcwEzYSyicQjkh6Odm8R2WhtcCKVZjkSrSq6YgqsjiXuoi7EGvEeNLLUXeVeFyc46jEdve9lOIoZcVkcJPP+iPBJGC/LTZQl6fGmZSaIdQlS6+sJrIkWpvnSZPZHmrwzqJTuQ1w5flw+ijZJ1hLLFDImcEhLgSFsrtYtTmcfeWjAl8AOv4KXdy4V2v0FVEEKUNsmAiMkc/e4BssQFa+WB06Tey/TG873zKELLE9/eoJnKHTl5F/qlwicJOD7HbbWrC4zxEoyA5i6wCKIImCPwvM4= BY2FFO11HUB024: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY2FFO11HUB024;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB024; X-Forefront-PRVS: 0632519F33 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJGRk8xMUhVQjAyNDsyMzpvS0tXQVNScFlWZVZuSXVYTDdBRWNhSVo1?= =?utf-8?B?SGpiYjcxczc5NHc0bVAxT3RScm1xdDZvREo0MmFuV0VHVi9hVHhuVW5uYnkv?= =?utf-8?B?SWtqTDdrSDF3S05nMVR1ck9iem5EWG9tVTdCRDE0eENybTIyVzdEODZ2K1JE?= =?utf-8?B?U1poQksvREdhQ3h4czhSeThObjFjNVJWK1BRK0ZHT2JnakNaMVoxUVJEd1oz?= =?utf-8?B?ZmdUWjI5Z2VXVGEzRVFid0pZNitlcHRDVVZobnhnbFMwcU0xRUVTNHBrOEVs?= =?utf-8?B?UnU1WDlXRFB1TVRIeXRvdFpTUlpPT3gxQ3MwUU9pRjhEVXhBR214d1pqZCti?= =?utf-8?B?cVZ5T3BZeDNMVENUYnlYc0JTbE9nY2pEN3BLU1RCTGh2Zys4c09VZE1sSVZM?= =?utf-8?B?UEVzUkcwdWcyOXlKSm9mUmZIc3RqQ0twODJBUVRBeTZPTUo3d0FZQnFjbytC?= =?utf-8?B?Vit2L2RuNFFXa050NytlTnlvYjVYWXVJMUlsKzV3REFFQnJDd1dqVjJuSVU5?= =?utf-8?B?UUhpcUZYbTltSEZZWnUzYmJndjg5WUZFTHVmbVAxUzRKSG84NHB6cmplaTJF?= =?utf-8?B?NTB4by94b3VQbUovZ1pIUnhCaXRPNkJmOVEwTVZKZ1RqWE5HOStyM0NQc3dz?= =?utf-8?B?aUZhbEthbC9BRG0zZDBGY2FSM1g3bWRYbFp4bkxxemV4ZVlkb0toMGFVUFFs?= =?utf-8?B?VTV2MUVDMU9QSEZneWlQbkRocDMvdzRzajgwK3JlTUpVVk5sbHR3U1htdkFx?= =?utf-8?B?eDBzMk83V0JDM0F2dnNxcmhhTGcwL2xzM1oxRjJrUUFBcjB5YkZrTGpxNDdV?= =?utf-8?B?L2gxUkFidG1Fai9CM0tIOG16d2pNYm03RHB3WFhjK0VRd1A5NGhqNXFOeDA5?= =?utf-8?B?L1RYbTNnT3hYdlhQd1FTTWtlT2pYQjJsTjhVdFdqV2V6VlhPMmh6Uld4Y1pw?= =?utf-8?B?WnYxbnM2SEZVcWZ1VEJvN1BBWTB6WnZUN3luWGZVSjlveHdLaHdzVnZQOHds?= =?utf-8?B?a0E0OE5MYkRDbG1GbjFmNDZ0S1lTeUdzeW9TZFlDZ3BiODZ5eisyNzJLN2da?= =?utf-8?B?cklNTE13N3kwUHZON2pVYW9PZHBmOGN2YzVxV05pLzJrd2llU2loUWZFem1a?= =?utf-8?B?SGNqMHFkNzc0dVl2cWsxdzZtU1ZoakpFamdUTTBxd2F5WXdNTGhWS0wzNlhS?= =?utf-8?B?dHArWWI4KzFQL2kvMFNURmJoTHc0MzFXVTZCQWVJVEs4Vnl5elI1QVRqZXVs?= =?utf-8?B?T0kzQm5GZk84Vm1qdVpyWFFOSWF2bDBPenhwYXRoSDdtRHAwWS9jSTVONytD?= =?utf-8?Q?6OC9pQuCJQ4olxNJDoxXG2qEh1hSCjSLo=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB024;5:wBL71jI/KZlpS4AL7Op17apiJEwvJuIxbwRuSzQtJV7k9fg2R/GANLv9QNWg6G6i5bbwBtt4zmEsXWHjUXwKWWjcfhRJaKPZ3U/f7jIvfl7oZ/bWw2+rS1gHaVwP0VOu42MHg1o2PL8mFZ8AgautXw==;24:Ntsobl7eEHjv8X9eYR5MfB/Jo6SRmTr66jHlQ0clH4PjD+76OGTLikFml+S3xCFEjlpqrNEbhV5fOS2QHNzMqlItM34QWIPaihEWCEW/SHs= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2015 21:04:00.7083 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2FFO11HUB024 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 16 On Thu, 2015-07-09 at 10:21PM +0900, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Cc: > Fixes: 46aa27df8853 ("net: axienet: Use devm_* calls") Reviewed-by: Sören Brinkmann Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/