Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754391AbbGIVQG (ORCPT ); Thu, 9 Jul 2015 17:16:06 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35392 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753609AbbGIVP5 (ORCPT ); Thu, 9 Jul 2015 17:15:57 -0400 Message-ID: <559EE423.9060503@gmail.com> Date: Thu, 09 Jul 2015 14:14:11 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stas Sergeev CC: Linux kernel , Sebastien Rannou , Arnaud Ebalard , Stas Sergeev , Thomas Petazzoni , netdev , stable@vger.kernel.org Subject: Re: [PATCH 2/2] mvneta: use inband status only when link type is "auto" References: <559EB0A4.5080101@list.ru> <559EB22E.7070607@list.ru> <559EBAFE.6040705@gmail.com> <559ED8F1.7050609@list.ru> In-Reply-To: <559ED8F1.7050609@list.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 35 On 09/07/15 13:26, Stas Sergeev wrote: > 09.07.2015 21:18, Florian Fainelli пишет: >> On 09/07/15 10:41, Stas Sergeev wrote: >>> The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link >>> state >>> signaling") implemented the link parameters auto-negotiation >>> unconditionally. >>> Unfortunately it appears that some HW that implements SGMII protocol, >>> doesn't generate the inband status, so it is not possible to >>> auto-negotiate >>> anything with such HW. >> What is the purpose of using the in-band status in the first place if >> you end-up having to specify a 'fixed-link' property which contains most >> of the link parameters: speed, duplex etc...? > You don't have to. > My config from today is as simple as: > > fixed-link { > link = "auto"; > }; > > and that's all. > Without my today's patch, only 'speed' is a mandatory - not too much. That makes me think that 'fixed-link' is not exactly what you want then, you would probably want something like "marvell,use-in-band-status" or something like this. It could be a more generic property that is not Marvell specific after all, that would be fine. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/