Date: Fri, 10 Jul 2015 00:44:06 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Christoph Lameter <cl@linux.com>,
        Rik van Riel <riel@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/5] kmod: Use system_unbound_wq instead of khelper
Message-ID: <20150709224406.GA17528@redhat.com>
References: <1436465237-22031-1-git-send-email-fweisbec@gmail.com> <1436465237-22031-3-git-send-email-fweisbec@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436465237-22031-3-git-send-email-fweisbec@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1478
Lines: 37

On 07/09, Frederic Weisbecker wrote:
>
> We need to launch the usermodehelper kernel threads with the widest
> affinity and this is why we have khelper for. This workqueue has unbound
> properties and thus a wide affinity inherited by all its children.
>
> Now khelper also has special properties that we aren't much interested
> in: ordered and singlethread. There is really no need about ordering as
> all we do is creating kernel threads. This can be done concurrently.
> And singlethread is a useless limitation as well.
>
> The workqueue engine already proposes generic unbound workqueues that
> don't share these useless properties and handle well parallel jobs.
>
> Lets just use them.
>
> Suggested-by: Oleg Nesterov <oleg@redhat.com>

Well yes, but it seems that you missed another part of my email ;)

If we just change usermodehelper to use system_unbound_wq then we
probably should keep set_cpus_allowed_ptr() removed by 4/5.

Note that system_unbound_wq has ->no_numa == F, so its worker threads
are NUMA bound. Perhaps this is not that bad, I do not know. But at
least this means that 4/5 needs more documentation/justification.

But as for this particular patch I obviously like it, khelper_wq
must die imo ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/