Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752166AbbGJBwj (ORCPT ); Thu, 9 Jul 2015 21:52:39 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:35569 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbbGJBwa convert rfc822-to-8bit (ORCPT ); Thu, 9 Jul 2015 21:52:30 -0400 MIME-Version: 1.0 In-Reply-To: <20150709205203.GD111846@vmdeb7> References: <20150629122953.GF16230@pali> <20150630085814.GE27720@pali> <20150701114849.GE17577@pali> <20150703072523.GB1841@pali> <20150706224328.GB111639@vmdeb7> <20150707142518.GI12087@pali> <20150709205203.GD111846@vmdeb7> Date: Fri, 10 Jul 2015 09:52:29 +0800 Message-ID: Subject: Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8 From: Alex Hung To: Darren Hart Cc: =?UTF-8?Q?Pali_Roh=C3=A1r?= , Corentin Chary , "platform-driver-x86@vger.kernel.org" , acpi4asus-user@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2715 Lines: 65 On Fri, Jul 10, 2015 at 4:52 AM, Darren Hart wrote: > On Tue, Jul 07, 2015 at 04:25:18PM +0200, Pali Rohár wrote: >> On Monday 06 July 2015 15:43:28 Darren Hart wrote: >> > On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote: >> > > ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and >> > > HP are doing it. It is just ASUS who decides LED should be controlled >> > > by software unlike HP whose LED is driven by hardware pins on mini >> > > card. >> > >> > Alex, please refrain from top posting on Linux kernel mailing lists, it breaks >> > the established practice the readers are setup for. >> > >> > Regarding the ATK4001 device, it did sound like it did more than control the >> > radios and the associcated LED. If that is all it does, then asus-rbtn is fine. >> > If it does something beyond that, we need understand what that is, as a more >> > platform-centric name would be more appropriate. >> > >> > Thanks, >> >> Yes, I understand too that ATK4001 device has more functions as one for >> LED control. And in this case it is not good to use name from one >> specific functionality. >> >> And about name: >> >> I chose name rbtn for dell driver because ACPI device in DSDT table is >> named RBTN and acpi id is DELRBTN. >> >> I think that acpi-rbtn.c (radio button) is not ideal name for driver >> which at SW level controls LED device associated with wireless devices. >> >> I would rather follow acpi device name, but in this case ATK4001 is even >> worse name which does not say anything... >> >> Maybe better name could be asus-wireless? Still I do not have any good >> name, so choose something... > > I suggested rbtn to try and start showing some kind of consistency in the > directory - however, it's no better than many of the other existing options, > including -rfkill -wireless -laptop, etc. > > Speaking of -laptop, the asus-laptop driver supports ATK0100 and ATK0101. This > ATK4001 device appears to perform the same type of features. The question is > whether or not it can be reasonably incorporated into the existing asus-laptop > driver or not. > > (I intended to do that review myself, but I haven't found the time in 48 hours, > so I'm just going to send this out and ask that Alex have a look and provide his > thoughts on asus-laptop) > > -- > Darren Hart > Intel Open Source Technology Center Certainly, I should have time to look into asus-laptop next week. -- Cheers, Alex Hung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/