Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbbGJDPE (ORCPT ); Thu, 9 Jul 2015 23:15:04 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:59454 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbbGJDOy (ORCPT ); Thu, 9 Jul 2015 23:14:54 -0400 Date: Thu, 9 Jul 2015 20:14:38 -0700 From: Guenter Roeck To: Josh Wu Cc: Nicolas Ferre , linux-arm-kernel@lists.infradead.org, Wei Yongjun , Alexandre Belloni , Ben Dooks , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Fabian Frederick , linux-pm@vger.kernel.org, Maxime Ripard Subject: Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Message-ID: <20150710031438.GA27089@roeck-us.net> References: <1436436947-11210-1-git-send-email-josh.wu@atmel.com> <20150709173747.GA32448@roeck-us.net> <559F2719.3060708@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559F2719.3060708@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1598 Lines: 38 On Fri, Jul 10, 2015 at 09:59:53AM +0800, Josh Wu wrote: > Hi, Guenter > > On 7/10/2015 1:37 AM, Guenter Roeck wrote: > >On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: > >>As since sama5d3, to reset the chip, we don't need to shutdown the ddr > >>controller. > >> > >>So add a new compatible string and new restart function for sama5d3 and > >>later chips. As we don't use sama5d3 ddr controller, so remove it as > >>well. > >> > >That sounds like it should be two separate patches, or am I missing something ? > > I think using one patch makes more sense. Maybe the commit log is not clear > enough. How about put it this way: > > This patch introduces a new compatible string: "atmel,sama5d3-rstc" for the > reset driver of sama5d3 and later chips. > As in sama5d3 or later chips, we don't have to shutdown the DDR controller > before reset. Shutdown the DDR controller before reset is a workaround to > avoid DDR signal driving the bus, but since sama5d3 and later chips there is > no such a conflict. > That means: > 1. the sama5d3 reset function only need to write the rstc register and > return. > 2. for sama5d3, we can remove the code related with DDR controller as we > don't use it at all. > Sorry, I don't get it. Doesn't that mean there are two distinct logical changes, which would ask for two separate patches ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/