Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbbGJDXg (ORCPT ); Thu, 9 Jul 2015 23:23:36 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:36389 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbbGJDX2 (ORCPT ); Thu, 9 Jul 2015 23:23:28 -0400 MIME-Version: 1.0 In-Reply-To: <1436473148.20619.116.camel@tiscali.nl> References: <20150709195944.GA4470@vaishali-Ideapad-Z570> <1436473148.20619.116.camel@tiscali.nl> Date: Fri, 10 Jul 2015 08:53:27 +0530 Message-ID: Subject: Re: [PATCH v2] coresight: replicator: Use module_platform_driver From: Vaishali Thakkar To: Paul Bolle Cc: Mathieu Poirier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 51 On Fri, Jul 10, 2015 at 1:49 AM, Paul Bolle wrote: > > On vr, 2015-07-10 at 01:29 +0530, Vaishali Thakkar wrote: > > --- a/drivers/hwtracing/coresight/coresight-replicator.c > > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > > > -static int __init replicator_init(void) > > -{ > > - return platform_driver_register(&replicator_driver); > > -} > > -module_init(replicator_init); > > - > > -static void __exit replicator_exit(void) > > -{ > > - platform_driver_unregister(&replicator_driver); > > -} > > -module_exit(replicator_exit); > > +module_platform_driver(replicator_driver); > > coresight-replicator.o is built if CONFIG_CORESIGHT_LINKS_AND_SINKS is > defined. CORESIGHT_LINKS_AND_SINKS is a bool symbol. It depends on > CORESIGHT, which is also a bool symbol. CORESIGHT is a top level symbol, > available on arm and arm64. > > I think coresight-replicator.o can only be built-in. So I suggest to use > builtin_platform_driver() instead. > I thought about this solution before sending this patch. But I was not sure about it. Thanks for the explanation. I will send v3 with this change. Can I add Suggested By: Paul Bolle > > Thanks, > > > Paul Bolle -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/