Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbbGJDi7 (ORCPT ); Thu, 9 Jul 2015 23:38:59 -0400 Received: from mail-vn0-f53.google.com ([209.85.216.53]:40711 "EHLO mail-vn0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbbGJDiw (ORCPT ); Thu, 9 Jul 2015 23:38:52 -0400 MIME-Version: 1.0 In-Reply-To: <5369372.r4v2a9W8l1@vostro.rjw.lan> References: <3814282.YWYCHNROVv@vostro.rjw.lan> <20150709051024.GJ1805@linux> <5369372.r4v2a9W8l1@vostro.rjw.lan> Date: Fri, 10 Jul 2015 09:08:51 +0530 Message-ID: Subject: Re: [PATCH] cpufreq: Initialize the governor again while restoring policy From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Linaro Kernel Mailman List , "linux-pm@vger.kernel.org" , Pi-Cheng Chen , "Jon Medhurst (Tixy)" , open list , Steven Rostedt Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 16 On 10 July 2015 at 05:35, Rafael J. Wysocki wrote: >> - Because governors matched, we skip governor initialization and return >> after calling __cpufreq_governor(CPUFREQ_GOV_LIMITS). > > But this sounds fragile in principle. What's the benefit from skipping the > governor initialization in that case? So this is the case where we have changed some property of the governor, and the governor is already initialised. We need to exit the earlier governor and initialize the new one only when the governor is actually switched. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/