Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbbGJEoR (ORCPT ); Fri, 10 Jul 2015 00:44:17 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47577 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbbGJEoG (ORCPT ); Fri, 10 Jul 2015 00:44:06 -0400 Date: Thu, 09 Jul 2015 21:44:05 -0700 (PDT) Message-Id: <20150709.214405.325044957551402588.davem@davemloft.net> To: k.kozlowski.k@gmail.com Cc: anirudh@xilinx.com, John.Linn@xilinx.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check From: David Miller In-Reply-To: <1436448080-24775-1-git-send-email-k.kozlowski.k@gmail.com> References: <1436448080-24775-1-git-send-email-k.kozlowski.k@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 09 Jul 2015 21:44:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 17 From: Krzysztof Kozlowski Date: Thu, 9 Jul 2015 22:21:20 +0900 > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Cc: > Fixes: 46aa27df8853 ("net: axienet: Use devm_* calls") Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/