Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbbGJF2S (ORCPT ); Fri, 10 Jul 2015 01:28:18 -0400 Received: from mail-by2on0148.outbound.protection.outlook.com ([207.46.100.148]:39269 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752160AbbGJF2K (ORCPT ); Fri, 10 Jul 2015 01:28:10 -0400 X-Greylist: delayed 77740 seconds by postgrey-1.27 at vger.kernel.org; Fri, 10 Jul 2015 01:28:10 EDT From: Zhao Qiang To: Scott Wood CC: "lauraa@codeaurora.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "akpm@linux-foundation.org" , "olof@lixom.net" , "catalin.marinas@arm.com" , "Xiaobo Xie" Subject: RE: [RFC] genalloc:add an gen_pool_alloc_align func to genalloc Thread-Topic: [RFC] genalloc:add an gen_pool_alloc_align func to genalloc Thread-Index: AQHQuhw0n2wxx4PzXUebBSIGj48Fyp3TtnAAgAB3g4A= Date: Fri, 10 Jul 2015 05:28:06 +0000 Message-ID: References: <1436428063-893-1-git-send-email-B45475@freescale.com> <1436480372.2658.153.camel@freescale.com> In-Reply-To: <1436480372.2658.153.camel@freescale.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freescale.com; dkim=none (message not signed) header.d=none; x-originating-ip: [192.158.241.86] x-microsoft-exchange-diagnostics: 1;CY1PR03MB1487;5:UcsAcy2Z3HC2jL7umW1HvwRIv6UYdRiK8OOYSJhE3GaB1/FHCrDCgzgmLiaQcPkqE5jRYlwLkzAFXjKk7/Bvyrm6RZndX658izDzoDf/lprWLpHh8lhK+sO7PquZQywoEZGfw3ZE+v7fVMPdkz4yRQ==;24:tvfbXXvnq4xXRelclm3Wgp9MKO6v614mQwGXQpMTQW+trvOMtcmCkLGwftbmsGHyeSYuQZkatsBewhmyWfzdAdJqNt0Kbg9LFBLYq54X44c=;20:DcH4PbhbfT3NZUaaMg99sJ1JS2FOeByoXdo0fwRwBesIOPn82erqGIy0s1jok1/DFS298l7/SJa7TnK7BV3kow== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; cy1pr03mb1487: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:CY1PR03MB1487;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; x-forefront-prvs: 06339BAE63 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(13464003)(377454003)(24454002)(377424004)(51704005)(5003600100002)(74316001)(189998001)(5001960100002)(107886002)(110136002)(66066001)(77156002)(62966003)(77096005)(102836002)(2950100001)(2900100001)(92566002)(5002640100001)(86362001)(76176999)(54356999)(46102003)(50986999)(106116001)(33656002)(99286002)(40100003)(122556002)(2656002)(87936001)(19580395003)(19580405001)(76576001)(4001450100001)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1487;H:SN1PR0301MB1550.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2015 05:28:06.7122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6A5SOsI005093 Content-Length: 1538 Lines: 40 > -----Original Message----- > From: Wood Scott-B07421 > Sent: Friday, July 10, 2015 6:20 AM > To: Zhao Qiang-B45475 > Cc: lauraa@codeaurora.org; linux-kernel@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; akpm@linux-foundation.org; olof@lixom.net; > catalin.marinas@arm.com; Xie Xiaobo-R63061 > Subject: Re: [RFC] genalloc:add an gen_pool_alloc_align func to genalloc > > On Thu, 2015-07-09 at 15:47 +0800, Zhao Qiang wrote: > > @@ -541,13 +562,14 @@ EXPORT_SYMBOL(gen_pool_first_fit_order_align); > > * which we can allocate the memory. > > */ > > unsigned long gen_pool_best_fit(unsigned long *map, unsigned long size, > > - unsigned long start, unsigned int nr, void *data) > > + unsigned long start, unsigned int nr, > > + void *data, unsigned long align_mask) > > { > > unsigned long start_bit = size; > > unsigned long len = size + 1; > > unsigned long index; > > > > - index = bitmap_find_next_zero_area(map, size, start, nr, 0); > > + index = bitmap_find_next_zero_area(map, size, start, nr, > align_mask); > > > > while (index < size) { > > int next_bit = find_next_bit(map, size, index + nr); > > What about the other call to bitmap_find_next_zero_area()? All others will pass the align_mask to bitmap_find_next_zero_area. > > -Scott ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?