Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753175AbbGJF5L (ORCPT ); Fri, 10 Jul 2015 01:57:11 -0400 Received: from down.free-electrons.com ([37.187.137.238]:37250 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753088AbbGJF5C (ORCPT ); Fri, 10 Jul 2015 01:57:02 -0400 Date: Fri, 10 Jul 2015 07:56:58 +0200 From: Alexandre Belloni To: Guenter Roeck Cc: Josh Wu , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, Wei Yongjun , Ben Dooks , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Fabian Frederick , linux-pm@vger.kernel.org, Maxime Ripard Subject: Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Message-ID: <20150710055658.GZ3127@piout.net> References: <1436436947-11210-1-git-send-email-josh.wu@atmel.com> <20150709173747.GA32448@roeck-us.net> <559F2719.3060708@atmel.com> <20150710031438.GA27089@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150710031438.GA27089@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1556 Lines: 35 Hi Guenter, On 09/07/2015 at 20:14:38 -0700, Guenter Roeck wrote : > > This patch introduces a new compatible string: "atmel,sama5d3-rstc" for the > > reset driver of sama5d3 and later chips. > > As in sama5d3 or later chips, we don't have to shutdown the DDR controller > > before reset. Shutdown the DDR controller before reset is a workaround to > > avoid DDR signal driving the bus, but since sama5d3 and later chips there is > > no such a conflict. > > That means: > > 1. the sama5d3 reset function only need to write the rstc register and > > return. > > 2. for sama5d3, we can remove the code related with DDR controller as we > > don't use it at all. > > > Sorry, I don't get it. Doesn't that mean there are two distinct logical > changes, which would ask for two separate patches ? I would agree with Josh and I think that only one patch is needed. There is only one change, the removal of the workaround for sama5d3 and later. As the workaround is using a table of compatibles to remap the ram controller and the one for sama5d3 is not used because it is not needed, I think it makes sense to remove it in that same patch. The logical change here is the removal of the workaround. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/