Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbbGJGvF (ORCPT ); Fri, 10 Jul 2015 02:51:05 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:34314 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbbGJGu5 (ORCPT ); Fri, 10 Jul 2015 02:50:57 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:S;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: k.kozlowski@samsung.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <17207ec52d1cc2fd2641c0e4aad7b94c> X-DNS-TYPE: 0 Message-ID: <559F6B3C.8080908@rock-chips.com> Date: Fri, 10 Jul 2015 14:50:36 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm: Drop owner assignment from i2c_driver References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2306 Lines: 62 On 2015年07月10日 13:36, Krzysztof Kozlowski wrote: > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > > The coccinelle script which generated the patch was sent here: > http://www.spinics.net/lists/kernel/msg2029903.html > --- > drivers/gpu/drm/bridge/ps8622.c | 1 - > drivers/gpu/drm/bridge/ptn3460.c | 1 - > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ps8622.c b/drivers/gpu/drm/bridge/ps8622.c > index 1a6607beb29f..be881e9fef8f 100644 > --- a/drivers/gpu/drm/bridge/ps8622.c > +++ b/drivers/gpu/drm/bridge/ps8622.c > @@ -668,7 +668,6 @@ static struct i2c_driver ps8622_driver = { > .remove = ps8622_remove, > .driver = { > .name = "ps8622", > - .owner = THIS_MODULE, > .of_match_table = ps8622_devices, > }, > }; > diff --git a/drivers/gpu/drm/bridge/ptn3460.c b/drivers/gpu/drm/bridge/ptn3460.c > index 1b1bf2384815..0ffa3a6a206a 100644 > --- a/drivers/gpu/drm/bridge/ptn3460.c > +++ b/drivers/gpu/drm/bridge/ptn3460.c > @@ -400,7 +400,6 @@ static struct i2c_driver ptn3460_driver = { > .remove = ptn3460_remove, > .driver = { > .name = "nxp,ptn3460", > - .owner = THIS_MODULE, > .of_match_table = ptn3460_match, > }, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index 01b558fe3695..9a0c2911272a 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -555,7 +555,6 @@ static struct platform_driver rockchip_drm_platform_driver = { > .probe = rockchip_drm_platform_probe, > .remove = rockchip_drm_platform_remove, > .driver = { > - .owner = THIS_MODULE, But rockchip drm is platform driver not i2c_driver, why remove its .owner ? -Mark > .name = "rockchip-drm", > .of_match_table = rockchip_drm_dt_ids, > .pm = &rockchip_drm_pm_ops, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/