Date: Fri, 10 Jul 2015 10:45:16 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Oleg Nesterov <oleg@redhat.com>, Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        Austin S Hemmelgarn <ahferroin7@gmail.com>,
        Brian Gerst <brgerst@gmail.com>, Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove
 EXPERT
Message-ID: <20150710084516.GA15959@gmail.com>
References: <dae7c0f1282a92e5eeac8b9fc389e2a02051d9cb.1436467147.git.luto@kernel.org>
 <559EC297.3030901@linux.intel.com>
 <CA+55aFzdBf4GPyR-+FRy3PkBdvp0f7PJ1xCx6SSUU=WN=PvUzw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFzdBf4GPyR-+FRy3PkBdvp0f7PJ1xCx6SSUU=WN=PvUzw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1182
Lines: 29


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> [...]
> 
> The one thing we might want to do is to rename the config option, simply to make 
> sure that people who do "make oldconfig" will actually see the new question and 
> hopefully pick the new default rather than just getting their old "y" without 
> even seeing it. Call the option "LEGACY_VM86" or something, perhaps?

Absolutely!

The 'default n' makes very little sense without changing the name - most distros 
have the old symbol already and will just grandfather in at whatever value it was.

Change the name and also update the help text to make it scarier: point out that 
it has known quirks and that we don't really trust the code because it's ancient, 
crippled on the hardware side because vm86 mode was never fully documented by CPU 
makers, back when x86 CPU makers (and Microsoft) considered virtualization an 
enemy of Windows revenue.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/