Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754193AbbGJJMu (ORCPT ); Fri, 10 Jul 2015 05:12:50 -0400 Received: from snt004-omc3s3.hotmail.com ([65.55.90.142]:51841 "EHLO SNT004-OMC3S3.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753397AbbGJJMp convert rfc822-to-8bit (ORCPT ); Fri, 10 Jul 2015 05:12:45 -0400 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Fri, 10 Jul 2015 05:12:45 EDT X-TMN: [fO/M7tHb4gWNWhYJ9B9pnf7UFCF9F8FY] X-Originating-Email: [indrakanti_ram@hotmail.com] Message-ID: From: Rama Kiran Kumar Indrakanti To: Krzysztof Kozlowski , Greg Kroah-Hartman , Jiri Slaby , Ralf Baechle , Paul Burton , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver Date: Fri, 10 Jul 2015 14:27:41 +0530 Importance: Normal In-Reply-To: <1436510180-5567-3-git-send-email-k.kozlowski@samsung.com> References: <1436510180-5567-1-git-send-email-k.kozlowski@samsung.com>,<1436510180-5567-3-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginalArrivalTime: 10 Jul 2015 08:57:41.0856 (UTC) FILETIME=[7AC68E00:01D0BAEE] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1995 Lines: 5

> From: k.kozlowski@samsung.com
> To: gregkh@linuxfoundation.org; jslaby@suse.cz; ralf@linux-mips.org; k.kozlowski@samsung.com; paul.burton@imgtec.com; linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver
> Date: Fri, 10 Jul 2015 15:36:20 +0900
>
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
> drivers/tty/serial/sc16is7xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 9e6576004a42..bbeb33561737 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1369,7 +1369,6 @@ MODULE_DEVICE_TABLE(i2c, sc16is7xx_i2c_id_table);
> static struct i2c_driver sc16is7xx_i2c_uart_driver = {
> .driver = {
> .name = SC16IS7XX_NAME,
> - .owner = THIS_MODULE,

Okay, is there an issue by doing this. Or its just a over doing things ?

> .of_match_table = of_match_ptr(sc16is7xx_dt_ids),
> },
> .probe = sc16is7xx_i2c_probe,
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/