Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753774AbbGJJA1 (ORCPT ); Fri, 10 Jul 2015 05:00:27 -0400 Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:50643 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbbGJJAU (ORCPT ); Fri, 10 Jul 2015 05:00:20 -0400 Message-ID: <1436518813.20619.134.camel@tiscali.nl> Subject: Re: [PATCH v2] coresight: replicator: Use module_platform_driver From: Paul Bolle To: Vaishali Thakkar Cc: Mathieu Poirier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 10 Jul 2015 11:00:13 +0200 In-Reply-To: References: <20150709195944.GA4470@vaishali-Ideapad-Z570> <1436473148.20619.116.camel@tiscali.nl> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 23 On vr, 2015-07-10 at 08:53 +0530, Vaishali Thakkar wrote: > I thought about this solution before sending this patch. But I was not > sure about it. Thanks for the explanation. I will send v3 with this > change. > > Can I add Suggested By: Paul Bolle That should be "Suggested-by:". The net effect would be that, if my suggestion turns out to be unwise, fan mail will also hit my INBOX, right? Anyhow, fine with me. By the way, there's more module specific stuff in drivers/hwtracing/coresight/. And there's no tristate symbol to be found in its Kconfig file. So I'd guess there are a few other cleanups possible too, if someone cared enough to have a closer look at that. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/