Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754188AbbGJJFO (ORCPT ); Fri, 10 Jul 2015 05:05:14 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:24054 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbbGJJFI (ORCPT ); Fri, 10 Jul 2015 05:05:08 -0400 X-IronPort-AV: E=Sophos;i="5.15,446,1432623600"; d="scan'208";a="69622589" Message-ID: <559F8ABE.2080805@broadcom.com> Date: Fri, 10 Jul 2015 11:05:02 +0200 From: Arend van Spriel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Vineet Gupta , Peter Zijlstra , Ingo Molnar , Arnd Bergmann CC: "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Brett Rudley , "Franky (Zhenhui) Lin" , Hante Meuleman , Kalle Valo , Pieter-Paul Giesberts , Daniel Kim , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list@broadcom.com" , "netdev@vger.kernel.org" Subject: Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive References: <1436429599-10762-1-git-send-email-vgupta@synopsys.com> <1436429599-10762-3-git-send-email-vgupta@synopsys.com> <559EBC91.2070600@broadcom.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 35 On 07/10/2015 06:49 AM, Vineet Gupta wrote: > On Thursday 09 July 2015 11:55 PM, Arend van Spriel wrote: >> On 07/09/2015 10:13 AM, Vineet Gupta wrote: >>>> There's already a generic implementation so use that instead. >> There is or there was? If there is now I am fine with this patch, but if >> it already was there the author might have had a reason for adding a >> local function and I would like to hear that reason. >> > > atomic_orr() was introduced to this driver with > > 2014-03-06 5cbb9c285bdc brcmfmac: Use atomic functions for intstatus update. > > as it seems atomic_set_mask() was not available cross arch. And atomic_or() in > generic code was indeed introduced after that > > 2014-04-23 560cb12a4080 locking,arch: Rewrite generic atomic support > > Hence likely the reason author went with home grown atomic_orr() Hi Vineet Thanks for looking into the timeline. Will look into it and let you know. Regards, Arend > -Vineet > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/