Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 9 Feb 2003 20:36:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 9 Feb 2003 20:36:58 -0500 Received: from dp.samba.org ([66.70.73.150]:37805 "EHLO lists.samba.org") by vger.kernel.org with ESMTP id ; Sun, 9 Feb 2003 20:36:56 -0500 From: Rusty Russell To: Frank Davis Cc: linux-kernel@vger.kernel.org Subject: re: smctr patch (with no subect) In-reply-to: Your message of "Fri, 07 Feb 2003 12:05:28 CDT." Date: Mon, 10 Feb 2003 11:20:02 +1100 Message-Id: <20030210014640.D2DD72C078@lists.samba.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 35 In message you write: > Hello all, > The following patch addresses buzilla bug # 312, and removes an > offending semicolon. Please review for inclusion. > > Regards, > Frank > > --- linux/drivers/net/tokenring/smctr.c.old 2003-01-16 21:22:09.000000000 - 0500 > +++ linux/drivers/net/tokenring/smctr.c 2003-02-07 03:10:50.000000000 - 0500 > @@ -3064,7 +3064,7 @@ > __u8 r; > > /* Check if node address has been specified by user. (non-0) */ > - for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++); > + for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++) > { > if(i != 6) > { NAK, I believe this is the way the code is supposed to work. Of course, opening a new block after the for is completely gratuitous and designed to fool the reader. Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/