Message-ID: <1436524977.24866.31.camel@perches.com>
Subject: Re: [PATCH v7 2/9] nvmem: Add a simple NVMEM framework for consumers
From: Joe Perches <joe@perches.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>,
        Mark Brown <broonie@kernel.org>, s.hauer@pengutronix.de,
        linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        arnd@arndb.de, sboyd@codeaurora.org, pantelis.antoniou@konsulko.com,
        mporter@konsulko.com, stefan.wahren@i2se.com, wxt@rock-chips.com,
        Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Fri, 10 Jul 2015 03:42:57 -0700
In-Reply-To: <1436521495-10728-1-git-send-email-srinivas.kandagatla@linaro.org>
References: <1436521427-10568-1-git-send-email-srinivas.kandagatla@linaro.org>
	 <1436521495-10728-1-git-send-email-srinivas.kandagatla@linaro.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2689
Lines: 102

On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote:
> This patch adds just consumers part of the framework just to enable easy
> review.

Trivial notes:

> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> @@ -334,6 +335,7 @@ struct nvmem_device *nvmem_register(struct nvmem_config *config)
>  	if (config->cells)
>  		nvmem_add_cells(nvmem, config);
>  
> +

superfluous newline

> +static struct nvmem_cell *nvmem_cell_get_from_list(const char *cell_id)
> +{
> +	struct nvmem_cell *cell = NULL;
> +	struct nvmem_device *nvmem;
> +
> +	nvmem = __nvmem_device_get(NULL, &cell, cell_id);
> +	if (IS_ERR(nvmem))
> +		return ERR_CAST(nvmem);
> +
> +

extra blank line here too

> +/**
> + * nvmem_cell_read() - Read a given nvmem cell
> + *
> + * @cell: nvmem cell to be read.
> + * @len: pointer to length of cell which will be populated on successful read.
> + *
> + * The return value will be an ERR_PTR() on error or a valid pointer
> + * to a char * bufffer.  The buffer should be freed by the consumer with a

One too many f's in buffer, it's returning a void *

> + * kfree().
> + */
> +void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
> +{
> +	struct nvmem_device *nvmem = cell->nvmem;
> +	u8 *buf;
[]
> +	return buf;
> +}
> +EXPORT_SYMBOL_GPL(nvmem_cell_read);

[]

> +/**
> + * nvmem_cell_write() - Write to a given nvmem cell
> + *
> + * @cell: nvmem cell to be written.
> + * @buf: Buffer to be written.
> + * @len: length of buffer to be written to nvmem cell.
> + *
> + * The return value will be an length of bytes written or non zero on failure.

less than zero or maybe negative on failure?

> + */
> +int nvmem_cell_write(struct nvmem_cell *cell, void *buf, size_t len)
> +{
> +	struct nvmem_device *nvmem = cell->nvmem;
> +	int rc;
> +	void *wbuf = buf;

This variable and assignment seems unnecessary as buf could be reused.

> +
> +	if (!nvmem || !nvmem->regmap || nvmem->read_only ||
> +	    (cell->bit_offset == 0 && len != cell->bytes))
> +		return -EINVAL;
> +
> +	if (cell->bit_offset || cell->nbits) {
> +		wbuf = nvmem_cell_prepare_write_buffer(cell, buf, len);
> +		if (IS_ERR(wbuf))
> +			return PTR_ERR(wbuf);
> +	}
> +
> +	rc = regmap_raw_write(nvmem->regmap, cell->offset, wbuf, cell->bytes);
> +
> +	/* free the tmp buffer */
> +	if (cell->bit_offset)
> +		kfree(wbuf);
> +
> +	if (IS_ERR_VALUE(rc))
> +		return rc;
> +
> +	return len;
> +}
> +EXPORT_SYMBOL_GPL(nvmem_cell_write);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/