Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754761AbbGJLxu (ORCPT ); Fri, 10 Jul 2015 07:53:50 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:43591 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753991AbbGJLxn (ORCPT ); Fri, 10 Jul 2015 07:53:43 -0400 X-Helo: d28dlp03.in.ibm.com X-MailFrom: srikar@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Fri, 10 Jul 2015 17:23:32 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ananth Mavinakayanahalli , Anton Arapov , David Long , Denys Vlasenko , "Frank Ch. Eigler" , Ingo Molnar , Jan Willeke , Jim Keniston , Mark Wielaard , Pratyush Anand , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/11] uprobes/x86: Reimplement arch_uretprobe_is_alive() Message-ID: <20150710115332.GG26095@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20150707012210.GA7466@redhat.com> <20150707012258.GA7533@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150707012258.GA7533@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15071011-0025-0000-0000-000005BE4EA7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 29 * Oleg Nesterov [2015-07-07 03:22:58]: > Add the x86-specific version of arch_uretprobe_is_alive() helper. > It returns true if the stack frame mangled by prepare_uretprobe() > is still on stack. So if it returns false, we know that the probed > function has already returned. > > We add the new return_instance->stack member and change the generic > code to initialize it in prepare_uretprobe, but it should be equally > useful for other architectures. > > TODO: this assumes that the probed application can't use multiple > stacks (say sigaltstack). We will try to improve this logic later. > > Signed-off-by: Oleg Nesterov Looks good to me. Acked-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/