Message-ID: <559FB65F.4060601@linaro.org>
Date: Fri, 10 Jul 2015 17:41:11 +0530
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Mark Brown <broonie@kernel.org>
CC: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com,
        sameo@linux.intel.com, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success
 status
References: <1436445692-10656-1-git-send-email-vaibhav.hiremath@linaro.org> <1436445692-10656-4-git-send-email-vaibhav.hiremath@linaro.org> <20150709190547.GQ11162@sirena.org.uk>
In-Reply-To: <20150709190547.GQ11162@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 948
Lines: 29


On Friday 10 July 2015 12:35 AM, Mark Brown wrote:
> On Thu, Jul 09, 2015 at 06:11:32PM +0530, Vaibhav Hiremath wrote:
>> This patch adds dev_info line at the end of probe function, to
>> clearly put status of regulator probe on console. Useful during
>> development, specially to check bootlog.
>
>> +	dev_info(&pdev->dev, "Regulator registered ...\n");
>>   	return 0;
>
> No, this is pure noise - all you're doing is slowing down boot for users
> with no content.  Think about what would happen if every driver did
> this.  The core already displays the constraints when things are
> registered.
>


I was just trying my luck here :)

And honestly, this was useful for me atleast.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/