Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932169AbbGJMmF (ORCPT ); Fri, 10 Jul 2015 08:42:05 -0400 Received: from foss.arm.com ([217.140.101.70]:50830 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbbGJMl6 (ORCPT ); Fri, 10 Jul 2015 08:41:58 -0400 Message-ID: <559FBD91.9070803@arm.com> Date: Fri, 10 Jul 2015 13:41:53 +0100 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Jiang Liu , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , "grant.likely@linaro.org" , Stuart Yoder , Yijing Wang , Borislav Petkov , Alexander Gordeev CC: Tony Luck , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC Patch V1 11/12] genirq, PCI: Reorginize struct msi_desc to prepare for support of generic MSI References: <1436428847-8886-1-git-send-email-jiang.liu@linux.intel.com> <1436428847-8886-12-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1436428847-8886-12-git-send-email-jiang.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2743 Lines: 83 Hi Gerry, On 09/07/15 09:00, Jiang Liu wrote: > Reorganize struct msi_desc so it could be reused by other MSI drivers. > > Signed-off-by: Jiang Liu > --- > include/linux/msi.h | 41 +++++++++++++++++++++-------------------- > 1 file changed, 21 insertions(+), 20 deletions(-) > > diff --git a/include/linux/msi.h b/include/linux/msi.h > index 5f77e231f515..f6845bc83774 100644 > --- a/include/linux/msi.h > +++ b/include/linux/msi.h > @@ -19,29 +19,30 @@ void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg); > void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg); > > struct msi_desc { > - struct { > - __u8 is_msix : 1; > - __u8 multiple: 3; /* log2 num of messages allocated */ > - __u8 multi_cap : 3; /* log2 num of messages supported */ > - __u8 maskbit : 1; /* mask-pending bit supported ? */ > - __u8 is_64 : 1; /* Address size: 0=32bit 1=64bit */ > - __u16 entry_nr; /* specific enabled entry */ > - unsigned default_irq; /* default pre-assigned irq */ > - } msi_attrib; > - > - u32 masked; /* mask bits */ > - unsigned int irq; > - unsigned int nvec_used; /* number of messages */ > - struct list_head list; > + struct list_head list; > + unsigned int irq; > + unsigned int nvec_used; /* number of messages */ > + struct device * dev; > + struct msi_msg msg; /* Last set MSI message */ > > union { > - void __iomem *mask_base; > - u8 mask_pos; > + struct { /* For PCI MSI/MSI-X */ > + u32 masked; /* mask bits */ > + struct { > + __u8 is_msix : 1; > + __u8 multiple: 3; /* log2 num of messages allocated */ > + __u8 multi_cap : 3; /* log2 num of messages supported */ > + __u8 maskbit : 1; /* mask-pending bit supported ? */ > + __u8 is_64 : 1; /* Address size: 0=32bit 1=64bit */ > + __u16 entry_nr; /* specific enabled entry */ > + unsigned default_irq; /* default pre-assigned irq */ > + } msi_attrib; > + union { > + u8 mask_pos; > + void __iomem *mask_base; > + }; > + }; Is this union the location where you would expect some non-PCI MSI infrastructure to store their own data? If that's the case, maybe a small comment to that effect would be good, as it is not completely obvious from looking at the data structure. > }; > - struct device *dev; > - > - /* Last set MSI message */ > - struct msi_msg msg; > }; > > /* Helpers to hide struct msi_desc implementation details */ > Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/