Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312AbbGJMzy (ORCPT ); Fri, 10 Jul 2015 08:55:54 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50924 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932139AbbGJMzl (ORCPT ); Fri, 10 Jul 2015 08:55:41 -0400 Date: Fri, 10 Jul 2015 14:46:20 +0200 From: Alexandre Belloni To: Maxime Ripard Cc: Josh Wu , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, Guenter Roeck , Wei Yongjun , Ben Dooks , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Fabian Frederick , linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Message-ID: <20150710124620.GD3127@piout.net> References: <1436436947-11210-1-git-send-email-josh.wu@atmel.com> <20150710060350.GA3127@piout.net> <559F7AC4.6050008@atmel.com> <20150710120907.GC3127@piout.net> <20150710123148.GA28632@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150710123148.GA28632@lukather> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 37 On 10/07/2015 at 14:31:48 +0200, Maxime Ripard wrote : > On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: > > Hi, > > > > On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : > > > I would agree with Maxime. Currently all latest chip reset function is > > > compatible with the atmel,sama5d3-rstc. > > > So check compatible string is enough for now. > > > But of cause if we have other incompatible reset in future with new chip, > > > the structure like you said is needed. > > > > We managed to avoid using of_machine_is_compatible() in all the at91 > > drivers. I'd like to keep it that way. It was painful enough to remove > > all those cpu_is_at91xxx calls. > > That's your call... > > > Also, using it is trying to match strings and will result in longer boot > > times. > > Have you looked at the implementation of of_match_device? If that's > really a concern to you, you should actually avoid it. > Indeed, I misread. of_device_is_compatible is acceptable, of_machine_is_compatible is not :) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/