Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932347AbbGJNBr (ORCPT ); Fri, 10 Jul 2015 09:01:47 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:36196 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932169AbbGJNBq (ORCPT ); Fri, 10 Jul 2015 09:01:46 -0400 X-IronPort-AV: E=Sophos;i="5.15,446,1432591200"; d="scan'208";a="139659936" Date: Fri, 10 Jul 2015 09:01:40 -0400 (EDT) From: Julia Lawall X-X-Sender: jll@hadrien To: Krzysztof Kozlowski cc: Julia Lawall , Gilles Muller , Nicolas Palix , Michal Marek , Wolfram Sang , Greg Kroah-Hartman , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coccinelle: api: extend spatch for dropping unnecessary owner In-Reply-To: <1436503986-21487-1-git-send-email-k.kozlowski@samsung.com> Message-ID: References: <1436503986-21487-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4957 Lines: 175 Acked-by: Julia Lawall As a semantic patch, it looks fine. Have you sent any patches based on it? I find hundreds of occurrences. julia On Fri, 10 Jul 2015, Krzysztof Kozlowski wrote: > i2c_add_driver (through i2c_register_driver) sets the owner field so we > can drop it also from i2c drivers, just like from platform drivers. > > Signed-off-by: Krzysztof Kozlowski > --- > scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/scripts/coccinelle/api/platform_no_drv_owner.cocci b/scripts/coccinelle/api/platform_no_drv_owner.cocci > index e065b9e714fc..c5e3f73f2054 100644 > --- a/scripts/coccinelle/api/platform_no_drv_owner.cocci > +++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci > @@ -9,11 +9,14 @@ virtual org > virtual report > > @match1@ > +declarer name module_i2c_driver; > declarer name module_platform_driver; > declarer name module_platform_driver_probe; > identifier __driver; > @@ > ( > + module_i2c_driver(__driver); > +| > module_platform_driver(__driver); > | > module_platform_driver_probe(__driver, ...); > @@ -28,6 +31,15 @@ identifier match1.__driver; > } > }; > > +@fix1_i2c depends on match1 && patch && !context && !org && !report@ > +identifier match1.__driver; > +@@ > + static struct i2c_driver __driver = { > + .driver = { > +- .owner = THIS_MODULE, > + } > + }; > + > @match2@ > identifier __driver; > @@ > @@ -37,6 +49,8 @@ identifier __driver; > platform_driver_probe(&__driver, ...) > | > platform_create_bundle(&__driver, ...) > +| > + i2c_add_driver(&__driver) > ) > > @fix2 depends on match2 && patch && !context && !org && !report@ > @@ -48,6 +62,15 @@ identifier match2.__driver; > } > }; > > +@fix2_i2c depends on match2 && patch && !context && !org && !report@ > +identifier match2.__driver; > +@@ > + static struct i2c_driver __driver = { > + .driver = { > +- .owner = THIS_MODULE, > + } > + }; > + > // ---------------------------------------------------------------------------- > > @fix1_context depends on match1 && !patch && (context || org || report)@ > @@ -61,6 +84,17 @@ position j0; > } > }; > > +@fix1_i2c_context depends on match1 && !patch && (context || org || report)@ > +identifier match1.__driver; > +position j0; > +@@ > + > + static struct i2c_driver __driver = { > + .driver = { > +* .owner@j0 = THIS_MODULE, > + } > + }; > + > @fix2_context depends on match2 && !patch && (context || org || report)@ > identifier match2.__driver; > position j0; > @@ -72,6 +106,17 @@ position j0; > } > }; > > +@fix2_i2c_context depends on match2 && !patch && (context || org || report)@ > +identifier match2.__driver; > +position j0; > +@@ > + > + static struct i2c_driver __driver = { > + .driver = { > +* .owner@j0 = THIS_MODULE, > + } > + }; > + > // ---------------------------------------------------------------------------- > > @script:python fix1_org depends on org@ > @@ -81,6 +126,13 @@ j0 << fix1_context.j0; > msg = "No need to set .owner here. The core will do it." > coccilib.org.print_todo(j0[0], msg) > > +@script:python fix1_i2c_org depends on org@ > +j0 << fix1_i2c_context.j0; > +@@ > + > +msg = "No need to set .owner here. The core will do it." > +coccilib.org.print_todo(j0[0], msg) > + > @script:python fix2_org depends on org@ > j0 << fix2_context.j0; > @@ > @@ -88,6 +140,13 @@ j0 << fix2_context.j0; > msg = "No need to set .owner here. The core will do it." > coccilib.org.print_todo(j0[0], msg) > > +@script:python fix2_i2c_org depends on org@ > +j0 << fix2_i2c_context.j0; > +@@ > + > +msg = "No need to set .owner here. The core will do it." > +coccilib.org.print_todo(j0[0], msg) > + > // ---------------------------------------------------------------------------- > > @script:python fix1_report depends on report@ > @@ -97,6 +156,13 @@ j0 << fix1_context.j0; > msg = "No need to set .owner here. The core will do it." > coccilib.report.print_report(j0[0], msg) > > +@script:python fix1_i2c_report depends on report@ > +j0 << fix1_i2c_context.j0; > +@@ > + > +msg = "No need to set .owner here. The core will do it." > +coccilib.report.print_report(j0[0], msg) > + > @script:python fix2_report depends on report@ > j0 << fix2_context.j0; > @@ > @@ -104,3 +170,10 @@ j0 << fix2_context.j0; > msg = "No need to set .owner here. The core will do it." > coccilib.report.print_report(j0[0], msg) > > +@script:python fix2_i2c_report depends on report@ > +j0 << fix2_i2c_context.j0; > +@@ > + > +msg = "No need to set .owner here. The core will do it." > +coccilib.report.print_report(j0[0], msg) > + > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/