Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932320AbbGJNrR (ORCPT ); Fri, 10 Jul 2015 09:47:17 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:42893 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753915AbbGJNrI (ORCPT ); Fri, 10 Jul 2015 09:47:08 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Hidehiro Kawai Cc: Andrew Morton , Vivek Goyal , linux-mips@linux-mips.org, Baoquan He , linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Ingo Molnar , HATAYAMA Daisuke , Masami Hiramatsu , Daniel Walker , linuxppc-dev@lists.ozlabs.org, linux-metag@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20150710113331.4368.10495.stgit@softrs> <20150710113331.4368.63745.stgit@softrs> Date: Fri, 10 Jul 2015 08:41:28 -0500 In-Reply-To: <20150710113331.4368.63745.stgit@softrs> (Hidehiro Kawai's message of "Fri, 10 Jul 2015 20:33:31 +0900") Message-ID: <87wpy82kqf.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-AID: U2FsdGVkX18ypCK++FMGkczAFmIJ8av3PM38uk8K084= X-SA-Exim-Connect-IP: 67.3.205.90 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.5 XMGappySubj_01 Very gappy subject * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Hidehiro Kawai X-Spam-Relay-Country: X-Spam-Timing: total 335 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 6 (1.9%), b_tie_ro: 3.6 (1.1%), parse: 1.61 (0.5%), extract_message_metadata: 22 (6.6%), get_uri_detail_list: 2.2 (0.7%), tests_pri_-1000: 11 (3.3%), tests_pri_-950: 1.44 (0.4%), tests_pri_-900: 1.20 (0.4%), tests_pri_-400: 21 (6.3%), check_bayes: 20 (5.9%), b_tokenize: 7 (2.0%), b_tok_get_all: 6 (1.8%), b_comp_prob: 1.86 (0.6%), b_tok_touch_all: 3.0 (0.9%), b_finish: 0.77 (0.2%), tests_pri_0: 259 (77.4%), tests_pri_500: 6 (1.8%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 24 Sep 2014 11:00:52 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1665 Lines: 47 Hidehiro Kawai writes: > You can call panic notifiers and kmsg dumpers before kdump by > specifying "crash_kexec_post_notifiers" as a boot parameter. > However, it doesn't make sense if kdump is not available. In that > case, disable "crash_kexec_post_notifiers" boot parameter so that > you can't change the value of the parameter. Nacked-by: "Eric W. Biederman" You are confusing kexec on panic and CONFIG_CRASH_DUMP which is about the tools for reading the state of the previous kernel. Eric > Signed-off-by: Hidehiro Kawai > Cc: Andrew Morton > Cc: Eric Biederman > Cc: Vivek Goyal > --- > kernel/panic.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/panic.c b/kernel/panic.c > index 04e91ff..5252331 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -502,12 +502,14 @@ __visible void __stack_chk_fail(void) > core_param(pause_on_oops, pause_on_oops, int, 0644); > core_param(panic_on_warn, panic_on_warn, int, 0644); > > +#ifdef CONFIG_CRASH_DUMP > static int __init setup_crash_kexec_post_notifiers(char *s) > { > crash_kexec_post_notifiers = true; > return 0; > } > early_param("crash_kexec_post_notifiers", setup_crash_kexec_post_notifiers); > +#endif > > static int __init oops_setup(char *s) > { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/