Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754295AbbGJOCK (ORCPT ); Fri, 10 Jul 2015 10:02:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33187 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbbGJOCA (ORCPT ); Fri, 10 Jul 2015 10:02:00 -0400 Date: Fri, 10 Jul 2015 16:01:55 +0200 From: Jan Kara To: Steve Magnani Cc: Jan Kara , linux-kernel@vger.kernel.org, "Steven J. Magnani" Subject: Re: [PATCH] udf: Don't corrupt unalloc spacetable when writing it Message-ID: <20150710140155.GA29102@quack.suse.cz> References: <1436292365-4395-1-git-send-email-steve@digidescorp.com> <20150709151603.GI2900@quack.suse.cz> <559EBB6B.1090902@digidescorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559EBB6B.1090902@digidescorp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1780 Lines: 50 On Thu 09-07-15 13:20:27, Steve Magnani wrote: > > > On 07/09/2015 10:16 AM, Jan Kara wrote: > >On Tue 07-07-15 13:06:05, Steven J. Magnani wrote: > >>For a UDF filesystem configured with an Unallocated Space Table, > >>a filesystem operation that triggers an update to the table results > >>in on-disk corruption that prevents remounting: > >> > >> udf_read_tagged: tag version 0x0000 != 0x0002 || 0x0003, block 274 > >> > >>For example: > >> 1. Create a filesystem > >> $ mkudffs --media-type=hd --blocksize=512 --lvid=BUGTEST \ > >> --vid=BUGTEST --fsid=BUGTEST --space=unalloctable \ > >> /dev/mmcblk0 > >> > >> 2. Mount it > >> # mount /dev/mmcblk0 /mnt > >> > >>... > >So the patch looks good to me. But what kind of mkudffs are you using? > >Because when I use the command you wrote into the changelog, I cannot mount > >the filesystem. The kernel complains about: > > > >UDF-fs: error (device ubdb): udf_read_inode: (ino 274) failed ident=256 > >mount: /dev/ubdb: can't read superblock > > > >Now ident 256 is TAG_IDENT_FSD (file set descriptor). So apparently my > >mkudffs doesn't create proper partition table with your parameters... > > > > > It identifies itself as: > mkudffs 1.0.0b2 for UDF FS 1.0.0-cvs, 2002/02/09 > > ...from Ubuntu udftools 1.0.0b3-14.2. OK, I've fixed my mkudffs and verified that your patch indeed fixes the problem. Thanks. I have merged the patch to my tree and will push it to Linus. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/