Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754698AbbGJO0K (ORCPT ); Fri, 10 Jul 2015 10:26:10 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33872 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754390AbbGJOZj (ORCPT ); Fri, 10 Jul 2015 10:25:39 -0400 Message-ID: <559FD5DB.9030308@linaro.org> Date: Fri, 10 Jul 2015 19:55:31 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Wolfram Sang CC: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robert.jarzmik@free.fr, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, "Jett.Zhou" Subject: Re: [PATCH-v3 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset References: <1436210695-19159-1-git-send-email-vaibhav.hiremath@linaro.org> <1436210695-19159-3-git-send-email-vaibhav.hiremath@linaro.org> <20150710081148.GB1528@katana> <559FBCD3.4050402@linaro.org> <20150710141440.GA6594@katana> In-Reply-To: <20150710141440.GA6594@katana> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1299 Lines: 37 On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote: > On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote: >> >> >> On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote: >>> On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote: >>>> Normally i2c controller works as master, so slave addr is not needed, or it >>>> will impact some slave device (eg. ST NFC chip) i2c accesses, because it has >>>> the same i2c address with controller. >>> >>> Just to make sure: Does it? As I read the code, slave interrupts are >>> enabled later only when slave mode is selected? Is that a HW bug? And if >>> so, can't the code just be moved into this #ifdef block later? >>> >> >> Yes we could, infact I thought about it; >> but I would break recommended sequence here. > > And did you set the "own slave address" to a value which one of your > existing i2c slaves also has (without enabling slave mode)? Did it > disturb communication? > Since slave and master mode are mutual exclusive, I did not try this. But I can try. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/