Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932330AbbGJOnf (ORCPT ); Fri, 10 Jul 2015 10:43:35 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:53477 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751286AbbGJOn1 (ORCPT ); Fri, 10 Jul 2015 10:43:27 -0400 X-Listener-Flag: 11101 Message-ID: <1436539401.6170.2.camel@mtksdaap41> Subject: Re: [PATCH 1/2] ASoC: rt5645: Fix missing free_irq From: Koro Chen To: Mark Brown CC: , , , , , , , Date: Fri, 10 Jul 2015 22:43:21 +0800 In-Reply-To: <20150709111010.GL11162@sirena.org.uk> References: <1436343951-3482-1-git-send-email-koro.chen@mediatek.com> <20150708111437.GQ11162@sirena.org.uk> <1436406493.15417.4.camel@mtksdaap41> <20150709111010.GL11162@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 19 On Thu, 2015-07-09 at 12:10 +0100, Mark Brown wrote: > On Thu, Jul 09, 2015 at 09:48:13AM +0800, Koro Chen wrote: > > > Do you think I should use devm_request_threaded_irq(), and change > > free_irq to devm_free_irq in remove? Or I should keep the original > > request_thread_irq(), and just add a free_irq() during probe failed? > > I'd just keep request_threaded_irq() and use free_irq(). OK, thanks, I will send a new patch. And about the patch 2/2 regulator support, is there any problem I should also fix? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/