Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932372AbbGJOrd (ORCPT ); Fri, 10 Jul 2015 10:47:33 -0400 Received: from foss.arm.com ([217.140.101.70]:51485 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932262AbbGJOrS (ORCPT ); Fri, 10 Jul 2015 10:47:18 -0400 Message-ID: <559FDAF3.10200@arm.com> Date: Fri, 10 Jul 2015 15:47:15 +0100 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "Moore, Robert" , Ming Lei , "Zheng, Lv" , "Wysocki, Rafael J" CC: Hanjun Guo , Thomas Gleixner , Linux Kernel Mailing List , linux-arm-kernel , Jason Cooper Subject: Re: ACPI: regression: Failed to initialize GIC IRQ controller References: <94F2FBAB4432B54E8AACC7DFDE6C92E37D30B295@ORSMSX112.amr.corp.intel.com> In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D30B295@ORSMSX112.amr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2178 Lines: 67 On 10/07/15 15:28, Moore, Robert wrote: > > >> -----Original Message----- >> From: Ming Lei [mailto:ming.lei@canonical.com] >> Sent: Friday, July 10, 2015 12:46 AM >> To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J >> Cc: Linux Kernel Mailing List; linux-arm-kernel; Thomas Gleixner; Jason >> Cooper; Hanjun Guo >> Subject: ACPI: regression: Failed to initialize GIC IRQ controller >> >> Hi, >> >> Commit 0cff8dc0099f6d4f(ACPICA: ACPI 6.0: Add changes for MADT table.) >> causes the following failure on APM mustang board(arm64) when booting via >> UEFI and ACPI: > > > I would be interested to know just what exactly about this change broke things. The gory details are there: https://lkml.org/lkml/2015/7/6/876 Basically, some data structure (acpi_madt_generic_interrupt) grew by 4 bytes from ACPI 5.1 to 6.0, but BAD_MADT_ENTRY only knows about the new size, and not the old one. When booting on an old(er) version of ACPI, the interrupt controller tables are ignore (not the right size), and the machine stops booting very early. Thanks, M. > Bob > > > >> >> No valid GICC entries exist >> ACPI: Failed to initialize GIC IRQ controller Kernel panic - not syncing: >> No interrupt controller found. >> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.2.0-rc1+ #45 Hardware name: >> APM X-Gene Mustang board (DT) Call trace: >> [] dump_backtrace+0x0/0x12c [] >> show_stack+0x10/0x1c [] dump_stack+0x8c/0xdc >> [] panic+0xe4/0x220 [] >> init_IRQ+0x24/0x30 [] start_kernel+0x274/0x3d8 ---[ end >> Kernel panic - not syncing: No interrupt controller found. >> >> >> Thanks, >> Ming > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/