Date: Fri, 10 Jul 2015 17:16:03 +0200
From: Joerg Roedel <jroedel@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        guangrong.xiao@linux.intel.com, joerg.roedel@suse.de
Subject: Re: [PATCH] KVM: svm: remove KVM_QUIRK_CD_NW_CLEARED quirk
Message-ID: <20150710151603.GI2566@suse.de>
References: <1436529693-9743-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436529693-9743-1-git-send-email-pbonzini@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1022
Lines: 26

On Fri, Jul 10, 2015 at 02:01:33PM +0200, Paolo Bonzini wrote:
> We can disable CD unconditionally when there is no assigned device.
> KVM now forces guest PAT to all-writeback in that case, so it makes
> sense to also force CR0.CD=0.
> 
> When there are assigned devices, emulate cache-disabled operation
> through the page tables.  This behavior is consistent with VMX,
> where CD/NW are not touched by vmentry/vmexit.
> 
> Note that buggy firmware that does not clear CD/NW is _seriously_
> old: SeaBIOS for example has been doing it since October 2008.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  arch/x86/kvm/svm.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Looks good to me.

Reviewed-by: Joerg Roedel <jroedel@suse.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/