Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754787AbbGJPrq (ORCPT ); Fri, 10 Jul 2015 11:47:46 -0400 Received: from mga11.intel.com ([192.55.52.93]:64343 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753821AbbGJPrh convert rfc822-to-8bit (ORCPT ); Fri, 10 Jul 2015 11:47:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,447,1432623600"; d="scan'208";a="603780398" From: "Moore, Robert" To: Lorenzo Pieralisi CC: Ming Lei , "Zheng, Lv" , "Wysocki, Rafael J" , Linux Kernel Mailing List , linux-arm-kernel , Thomas Gleixner , Jason Cooper , "hanjun.guo@linaro.org" Subject: RE: ACPI: regression: Failed to initialize GIC IRQ controller Thread-Topic: ACPI: regression: Failed to initialize GIC IRQ controller Thread-Index: AQHQuuSGbkQEjEXFHUKyyD3LW1itcZ3Uw2TAgAB5u4D//4reQIAAfrEA//+Sl+A= Date: Fri, 10 Jul 2015 15:47:34 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D30B373@ORSMSX112.amr.corp.intel.com> References: <94F2FBAB4432B54E8AACC7DFDE6C92E37D30B295@ORSMSX112.amr.corp.intel.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37D30B2E9@ORSMSX112.amr.corp.intel.com> <20150710151740.GB12489@red-moon> In-Reply-To: <20150710151740.GB12489@red-moon> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3050 Lines: 78 > -----Original Message----- > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > Sent: Friday, July 10, 2015 8:18 AM > To: Moore, Robert > Cc: Ming Lei; Zheng, Lv; Wysocki, Rafael J; Linux Kernel Mailing List; > linux-arm-kernel; Thomas Gleixner; Jason Cooper; hanjun.guo@linaro.org > Subject: Re: ACPI: regression: Failed to initialize GIC IRQ controller > > On Fri, Jul 10, 2015 at 03:45:32PM +0100, Moore, Robert wrote: > > It's nice that someone took a sizeof() on the struct -- so, one would > hope that no code actually depended on a particular value, no? > > Unfortunately that sizeof has been there forever (x86/ia64), > ia64 code ran into a similar issue, so the check was removed to cope with > lsapic MADT updates, see: > > arch/ia64/kernel/acpi.c line 204 > > /*Skip BAD_MADT_ENTRY check, as lsapic size could vary */ > > Is checking the subtable length field against a static value really > worthwhile/suitable ? > I would at least traverse the subtables via the subtable length given in the table, and not use a sizeof() for each subtable. Then, multiple table/subtable versions are handled automatically; you don't have to use any new fields until necessary. > Thanks, > Lorenzo > > > > -----Original Message----- > > > From: Ming Lei [mailto:ming.lei@canonical.com] > > > Sent: Friday, July 10, 2015 7:43 AM > > > To: Moore, Robert > > > Cc: Zheng, Lv; Wysocki, Rafael J; Linux Kernel Mailing List; > > > linux-arm- kernel; Thomas Gleixner; Jason Cooper; Hanjun Guo > > > Subject: Re: ACPI: regression: Failed to initialize GIC IRQ > > > controller > > > > > > On Fri, Jul 10, 2015 at 10:28 PM, Moore, Robert > > > > > > wrote: > > > > > > > > > > > >> -----Original Message----- > > > >> From: Ming Lei [mailto:ming.lei@canonical.com] > > > >> Sent: Friday, July 10, 2015 12:46 AM > > > >> To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J > > > >> Cc: Linux Kernel Mailing List; linux-arm-kernel; Thomas Gleixner; > > > >> Jason Cooper; Hanjun Guo > > > >> Subject: ACPI: regression: Failed to initialize GIC IRQ > > > >> controller > > > >> > > > >> Hi, > > > >> > > > >> Commit 0cff8dc0099f6d4f(ACPICA: ACPI 6.0: Add changes for MADT > > > >> table.) causes the following failure on APM mustang board(arm64) > > > >> when booting via UEFI and ACPI: > > > > > > > > > > > > I would be interested to know just what exactly about this change > > > > broke > > > things. > > > > > > sizeof(struct acpi_madt_generic_interrupt) > > > N???????????????r??????y?????????b???X????????v???^???)??{.n???+?????????? > ??{????????????zX??????????????}???????????z???&j:+v????????? > ????????????zZ+??????+zf?????????h?????????~????????????i?????????z?????? > w??????????????????????&???)??f??????^j??y???m??????@A???a????????? > > 0??????h??????i -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/