Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754888AbbGJQgX (ORCPT ); Fri, 10 Jul 2015 12:36:23 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:33251 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754808AbbGJQgO (ORCPT ); Fri, 10 Jul 2015 12:36:14 -0400 Message-ID: <559FF47A.5000001@cogentembedded.com> Date: Fri, 10 Jul 2015 19:36:10 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Phil Edworthy , Kishon Vijay Abraham I CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Yoshihiro Shimoda , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0 References: <1436270121-25924-1-git-send-email-phil.edworthy@renesas.com> In-Reply-To: <1436270121-25924-1-git-send-email-phil.edworthy@renesas.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 31 Hello. On 07/07/2015 02:55 PM, Phil Edworthy wrote: > Instead of statically selecting the PHY connection to either the > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the > dts to specifiy gpio pins for the vbus and id signals. Additional These GPIOs don't have anything to do with the PHY, they're interfacing Maxim MAX3355 OTG chip for which I have submitted the extcon driver. > gpio pins are used to control power to an external OTG device and > an override to turn vbus on/off. > Note: the R-Car USB PHY only allows this Host/Function switching > on channel 0. > This has been tested on a r8a7791 based Koelsch board, which uses > a MAX3355 device to supply vbus power when needed. > Signed-off-by: Phil Edworthy I'm inclined to NAK this. You're modifying the wrong driver, I think. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/