Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932986AbbGJQ7f (ORCPT ); Fri, 10 Jul 2015 12:59:35 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:33843 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932967AbbGJQ7X (ORCPT ); Fri, 10 Jul 2015 12:59:23 -0400 Date: Fri, 10 Jul 2015 19:02:07 +0200 From: Daniel Vetter To: Jianwei Wang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, airlied@linux.ie, daniel.vetter@ffwll.ch, mark.yao@rock-chips.com, scottwood@freescale.com, thierry.reding@gmail.com, Alison Wang , Xiubo Li Subject: Re: [PATCH v7 1/4] drm/layerscape: Add Freescale DCU DRM driver Message-ID: <20150710170207.GF3736@phenom.ffwll.local> Mail-Followup-To: Jianwei Wang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, airlied@linux.ie, mark.yao@rock-chips.com, scottwood@freescale.com, thierry.reding@gmail.com, Alison Wang , Xiubo Li References: <1436527063-44762-1-git-send-email-jianwei.wang@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436527063-44762-1-git-send-email-jianwei.wang@freescale.com> X-Operating-System: Linux phenom 4.2.0-rc1+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2456 Lines: 60 On Fri, Jul 10, 2015 at 07:17:40PM +0800, Jianwei Wang wrote: > This patch add support for Two Dimensional Animation and Compositing > Engine (2D-ACE) on the Freescale SoCs. > > 2D-ACE is a Freescale display controller. 2D-ACE describes > the functionality of the module extremely well its name is a value > that cannot be used as a token in programming languages. > Instead the valid token "DCU" is used to tag the register names and > function names. > > The Display Controller Unit (DCU) module is a system master that > fetches graphics stored in internal or external memory and displays > them on a TFT LCD panel. A wide range of panel sizes is supported > and the timing of the interface signals is highly configurable. > Graphics are read directly from memory and then blended in real-time, > which allows for dynamic content creation with minimal CPU > intervention. > > The features: > (1) Full RGB888 output to TFT LCD panel. > (2) For the current LCD panel, WQVGA "480x272" is supported. > (3) Blending of each pixel using up to 4 source layers > dependent on size of panel. > (4) Each graphic layer can be placed with one pixel resolution > in either axis. > (5) Each graphic layer support RGB565 and RGB888 direct colors > without alpha > channel and BGRA8888 BGRA4444 ARGB1555 direct colors with an > alpha channel and > YUV422 format. > (6) Each graphic layer support alpha blending with 8-bit > resolution. > > This is a simplified version, only one primary plane, one > framebuffer created for > fbdev, one crtc, one connector for TFT LCD panel, an encoder. > > Signed-off-by: Alison Wang > Signed-off-by: Xiubo Li > Signed-off-by: Jianwei Wang Can't find any other use of deprecated functions or legacy code patterns or anything else that we've recently started cleaning up, looks good. No detailed review though (for one I lack hw docs). Acked-by: Daniel Vetter Might be good to get some cross-review from some other arm soc drm driver team, then send a pull request to Dave for 4.3. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/