Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932695AbbGJRJB (ORCPT ); Fri, 10 Jul 2015 13:09:01 -0400 Received: from mta-out1.inet.fi ([62.71.2.229]:56881 "EHLO johanna4.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbbGJRIx (ORCPT ); Fri, 10 Jul 2015 13:08:53 -0400 RazorGate-KAS: Rate: 5 RazorGate-KAS: {RECEIVED: dynamic ip detected} RazorGate-KAS: Envelope from: RazorGate-KAS: Version: 5.5.3 RazorGate-KAS: LuaCore: 215 2015-05-29_17-31-22 60ae4a1b4d01d14f868b20a55aced8d7df7b2e28 RazorGate-KAS: Method: none RazorGate-KAS: Lua profiles 78662 [Jun 02 2015] RazorGate-KAS: Status: not_detected Date: Fri, 10 Jul 2015 20:08:14 +0300 From: "Kirill A. Shutemov" To: Oleg Nesterov Cc: Andrew Morton , Andy Lutomirski , Hugh Dickins , Kirill Shutemov , Linus Torvalds , Pavel Emelyanov , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] special_mapping_fault() is broken Message-ID: <20150710170814.GA910@node.dhcp.inet.fi> References: <20150710165121.GA10341@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150710165121.GA10341@redhat.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 28 On Fri, Jul 10, 2015 at 06:51:21PM +0200, Oleg Nesterov wrote: > Hello, > > special_mapping_fault() is absolutely broken. It seems it was always > wrong, but this didn't matter until vdso/vvar started to use more than > one page. > > The patches are the same, just 1/3 was re-diffed on top of the recent > 6b7339f4c31ad "mm: avoid setting up anonymous pages into file mapping" > from Kirill. > > And after this change vma_is_anonymous() becomes really trivial, it > simply checks vm_ops == NULL. However, I do think the helper makes > sense. There are a lot of ->vm_ops != NULL checks, the helper makes > the caller's code more understandable (self-documented) and this is > more grep-friendly. For all three: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/