Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933153AbbGJRNi (ORCPT ); Fri, 10 Jul 2015 13:13:38 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34120 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932380AbbGJRNa (ORCPT ); Fri, 10 Jul 2015 13:13:30 -0400 Date: Fri, 10 Jul 2015 10:13:26 -0700 From: Guenter To: Vivien Didelot Cc: netdev@vger.kernel.org, "David S. Miller" , Andrew Lunn , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH 2/2] net: dsa: mv88e6xxx: call _mv88e6xxx_stats_wait with SMI lock held Message-ID: <20150710171326.GC6585@groeck-UX31A> References: <1436547449-26927-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1436547449-26927-2-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436547449-26927-2-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 16 On Fri, Jul 10, 2015 at 12:57:29PM -0400, Vivien Didelot wrote: > At switch setup, _mv88e6xxx_stats_wait was called without holding the > SMI mutex. Fix this by requesting the lock for this call. > > Also, return the _mv88e6xxx_stats_wait code, since it may fail. > > Signed-off-by: Vivien Didelot Good catch. Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/