Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933082AbbGJUJQ (ORCPT ); Fri, 10 Jul 2015 16:09:16 -0400 Received: from smtp10.mail.ru ([94.100.181.92]:52652 "EHLO smtp10.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932641AbbGJUJJ (ORCPT ); Fri, 10 Jul 2015 16:09:09 -0400 Subject: Re: [PATCH 2/3] of_mdio: add new DT property 'autoneg' for fixed-link To: Florian Fainelli , netdev References: <559FF511.5080102@list.ru> <559FF63E.8020209@list.ru> <55A010F9.7030808@gmail.com> Cc: Linux kernel , Sebastien Rannou , Arnaud Ebalard , Stas Sergeev , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , "devicetree@vger.kernel.org" From: Stas Sergeev Message-ID: <55A02656.7020508@list.ru> Date: Fri, 10 Jul 2015 23:08:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <55A010F9.7030808@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam: Not detected X-Mras: Ok Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2557 Lines: 56 10.07.2015 21:37, Florian Fainelli пишет: > On 10/07/15 09:43, Stas Sergeev wrote: >> Currently for fixed-link the MAC driver decides whether to use the >> link status auto-negotiation or not. >> Unfortunately the auto-negotiation may not work when expected by >> the MAC driver. Sebastien Rannou explains: >> << Yes, I confirm that my HW does not generate an in-band status. AFAIK, it's >> a PHY that aggregates 4xSGMIIs to 1xQSGMII ; the MAC side of the PHY (with >> inband status) is connected to the switch through QSGMII, and in this context >> we are on the media side of the PHY. >> >> https://lkml.org/lkml/2015/7/10/206 >> >> This patch introduces the new boolean property 'autoneg' that allows >> the user to request the auto-negotiation explicitly. > The implementation looks better, but the name might still be slightly > controversial. I would go with "use-in-band-status" which is more > strictly defined than "autoneg" which could mean anything and everything. > > What do you think? I actually think autoneg is a bit better. - Autonegotiation is a widely used and known term: https://en.wikipedia.org/wiki/Autonegotiation And who knows what in-band status is? And, more importantly, who knows what is it used for? Who even knows it is used for autonegotiation? - When we set autoneg for fixed-link, we basically just say "no MDIO here, but please do autoneg by any other means, if possible". - in-band status is an implementation delail, and it is specific to a particular protocols. If you request the in-band status for some protocol that doesn't support it, perhaps you should get -EINVAL, because such a config makes no sense. With autonegotiation, the rules are not that strict: it can be "unimplemented", which doesn't necessary mean nonsense in the config. - autonegotiation is a wider term, and may be implemented by some other means than the in-band status (which is probably impossible for a fixed-link though). - In the terms that the driver uses, it is autonegotiation, eg MVNETA_GMAC_AUTONEG_CONFIG. And when you go down the implementation details, you see MVNETA_GMAC_INBAND_AN_ENABLE, which is just one AN bit of many. So I really would prefer to keep things as is. But if you insist, I can rename, but there will still be no -EINVAL checks for obviously wrong configs. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/