From: Roy Pledge <roy.pledge@freescale.com>
To: Scott Wood <scottwood@freescale.com>, Paul Bolle <pebolle@tiscali.nl>
CC: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management
 driver
Thread-Topic: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management
 driver
Thread-Index: AQHQuohY2rDMKNe3ZkWysPaDcXIDnp3UlB8AgABj0YCAADhSYA==
Date: Fri, 10 Jul 2015 20:57:53 +0000
Message-ID: <BN3PR0301MB12673A340E327986F0BC39E58C9F0@BN3PR0301MB1267.namprd03.prod.outlook.com>
References: <1436473322-21247-1-git-send-email-Roy.Pledge@freescale.com>
	 <1436473322-21247-3-git-send-email-Roy.Pledge@freescale.com>
	 <1436528160.20619.159.camel@tiscali.nl>
 <1436549595.2658.159.camel@freescale.com>
In-Reply-To: <1436549595.2658.159.camel@freescale.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2015 20:57:53.8837
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1476
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6AKwDqD010598
Content-Length: 1001
Lines: 19

> 
> On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote:
> > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
> > > +#ifdef CONFIG_FSL_DPA_CHECKING
> > > +#define DPA_ASSERT(x) \
> > > +   do { \
> > > +           if (!(x)) { \
> > > +                   pr_crit("ASSERT: (%s:%d) %s\n", __FILE__, __LINE__, \
> > > +                           __stringify_1(x)); \
> > > +                   dump_stack(); \
> > > +                   panic("assertion failure"); \
> >
> > Not my call, but why panic() here?
> 
> I'm pretty sure I've complained about this before (as well as all the
> BUG_ONs).
> 
Is the concern here just the call to panic()?  I'm happy to change what happens when an issue is detected but the DPA_ASSERT() calls are very useful when testing changes to the driver and when bringing up the drivers on new silicon variants. 
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?