Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284AbbGKGM5 (ORCPT ); Sat, 11 Jul 2015 02:12:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:40311 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbbGKGM4 (ORCPT ); Sat, 11 Jul 2015 02:12:56 -0400 Date: Fri, 10 Jul 2015 17:17:15 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix to release inode page in get_new_data_page Message-ID: <20150711001715.GA61190@jaegeuk-mac02> References: <00f301d0ba30$ebe95b80$c3bc1280$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00f301d0ba30$ebe95b80$c3bc1280$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 46 Hi Chao, On Thu, Jul 09, 2015 at 06:20:08PM +0800, Chao Yu wrote: > get_new_data_page should release inode page when we encounter any > error in its procedure, but there is one error path didn't cover > this, fix it. Nice catch. But, I think we should fix its caller: in init_inode_metadata(), err = make_empty_dir(); if (err) goto put_error; --------------- Thanks, > > Signed-off-by: Chao Yu > --- > fs/f2fs/data.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 08dfdc6..ea8898b 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -397,8 +397,10 @@ struct page *get_new_data_page(struct inode *inode, > int err; > repeat: > page = grab_cache_page(mapping, index); > - if (!page) > + if (!page) { > + f2fs_put_page(ipage, 1); > return ERR_PTR(-ENOMEM); > + } > > set_new_dnode(&dn, inode, ipage, NULL, 0); > err = f2fs_reserve_block(&dn, index); > -- > 2.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/