Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248AbbGKGTg (ORCPT ); Sat, 11 Jul 2015 02:19:36 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:32966 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752451AbbGKGTf (ORCPT ); Sat, 11 Jul 2015 02:19:35 -0400 MIME-Version: 1.0 In-Reply-To: <1436447969-24583-1-git-send-email-k.kozlowski.k@gmail.com> References: <1436447969-24583-1-git-send-email-k.kozlowski.k@gmail.com> Date: Sat, 11 Jul 2015 10:02:28 +0800 Message-ID: Subject: Re: [RFT PATCH 1/2] ASoC: zx: i2s: Fix devm_ioremap_resource return value check From: Jun Nie To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 41 2015-07-09 21:19 GMT+08:00 Krzysztof Kozlowski : > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Cc: > Fixes: e5d4cd87800c ("ASoC: zx: Add ZTE zx296702 I2S DAI driver") > > --- > > Patch only compile tested. > --- > sound/soc/zte/zx296702-i2s.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/zte/zx296702-i2s.c b/sound/soc/zte/zx296702-i2s.c > index 98d96e1b17e0..1930c42e1f55 100644 > --- a/sound/soc/zte/zx296702-i2s.c > +++ b/sound/soc/zte/zx296702-i2s.c > @@ -393,9 +393,9 @@ static int zx_i2s_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > zx_i2s->mapbase = res->start; > zx_i2s->reg_base = devm_ioremap_resource(&pdev->dev, res); > - if (!zx_i2s->reg_base) { > + if (IS_ERR(zx_i2s->reg_base)) { > dev_err(&pdev->dev, "ioremap failed!\n"); > - return -EIO; > + return PTR_ERR(zx_i2s->reg_base); > } > > writel_relaxed(0, zx_i2s->reg_base + ZX_I2S_FIFO_CTRL); > -- > 2.1.4 > Reviewed-by: Jun Nie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/