Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753580AbbGKHQe (ORCPT ); Sat, 11 Jul 2015 03:16:34 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:34817 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753046AbbGKHQc (ORCPT ); Sat, 11 Jul 2015 03:16:32 -0400 Message-ID: <55A0C2CB.6060209@samsung.com> Date: Sat, 11 Jul 2015 16:16:27 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Vaibhav Hiremath , linux-arm-kernel@lists.infradead.org CC: devicetree@vger.kernel.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lee.jones@linaro.org Subject: Re: [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable References: <1436442431-3471-1-git-send-email-vaibhav.hiremath@linaro.org> <1436442431-3471-6-git-send-email-vaibhav.hiremath@linaro.org> In-Reply-To: <1436442431-3471-6-git-send-email-vaibhav.hiremath@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1672 Lines: 44 W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: > 88PM860 family of device supports dual phase mode on BUCK1 supply > providing total 6A capacity. > Note that by default they operate independently with 3A capacity. > > This patch adds the devicetree binding to enable this > feature. > > Signed-off-by: Vaibhav Hiremath > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > index ae1311c..c756b31 100644 > --- a/Documentation/devicetree/bindings/mfd/88pm800.txt > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -15,6 +15,12 @@ Optional properties : > CLK32K3 - for 88pm800 > CLK32K2 - for 88pm860 > > + (Applicable only to PXA910 family): > + > + - marvell,88pm860-buck1-dualphase-en : If set, enable dual phase on BUCK1, > + providing 6A capacity. > + Without this both BUCK1A and BUCK1B operates independently with 3A capacity. > + 1. How does this relates to regulator driver? The drivers/regulator/88pm800.c defines constraints for regulator which may be contradictory. 2. This looks like a job for regulator driver, not MFD. Then you could use standard regulator bindings (setting maximum current to 6A would change the regulator to different mode). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/