Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753018AbbGKLXl (ORCPT ); Sat, 11 Jul 2015 07:23:41 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:50390 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752112AbbGKLXk (ORCPT ); Sat, 11 Jul 2015 07:23:40 -0400 Date: Sat, 11 Jul 2015 04:23:38 -0700 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Cc: Bob Liu , linux-kernel@vger.kernel.org, axboe@fb.com, hch@infradead.org, xen-devel@lists.xenproject.org, avanzini.arianna@gmail.com, david.vrabel@citrix.com, marcus.granado@citrix.com, roger.pau@citrix.com Subject: Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs Message-ID: <20150711112338.GA29746@infradead.org> References: <1436176608-18237-1-git-send-email-bob.liu@oracle.com> <20150710195714.GB31146@l.oracle.com> <55A0D162.1020002@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 15 On Sat, Jul 11, 2015 at 07:17:18AM -0400, Konrad Rzeszutek Wilk wrote: > The 'locked' parameter can be used to tell the function to not take the lock. > > But it would drop the lock in both cases. Konrad, no conditional locking please. Split the functionality up in multiple functions if you may call with or without a lock held. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/