Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753032AbbGKLzF (ORCPT ); Sat, 11 Jul 2015 07:55:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38910 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325AbbGKLzD convert rfc822-to-8bit (ORCPT ); Sat, 11 Jul 2015 07:55:03 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20150711112338.GA29746@infradead.org> References: <1436176608-18237-1-git-send-email-bob.liu@oracle.com> <20150710195714.GB31146@l.oracle.com> <55A0D162.1020002@oracle.com> <20150711112338.GA29746@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Subject: Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs From: Konrad Rzeszutek Wilk Date: Sat, 11 Jul 2015 07:54:31 -0400 To: Christoph Hellwig CC: Bob Liu , linux-kernel@vger.kernel.org, axboe@fb.com, xen-devel@lists.xenproject.org, avanzini.arianna@gmail.com, david.vrabel@citrix.com, marcus.granado@citrix.com, roger.pau@citrix.com Message-ID: X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 19 On July 11, 2015 7:23:38 AM EDT, Christoph Hellwig wrote: >On Sat, Jul 11, 2015 at 07:17:18AM -0400, Konrad Rzeszutek Wilk wrote: >> The 'locked' parameter can be used to tell the function to not take >the lock. >> >> But it would drop the lock in both cases. > >Konrad, > >no conditional locking please. Split the functionality up in multiple >functions if you may call with or without a lock held. That would work nicely too. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/