Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750957AbbGKNF2 (ORCPT ); Sat, 11 Jul 2015 09:05:28 -0400 Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:55638 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701AbbGKNF0 (ORCPT ); Sat, 11 Jul 2015 09:05:26 -0400 Message-ID: <1436619923.2679.5.camel@tiscali.nl> Subject: Re: [PATCH] Add generic driver for Silead tochscreens From: Paul Bolle To: Robert Dolca Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg Date: Sat, 11 Jul 2015 15:05:23 +0200 In-Reply-To: <1436541064-13381-1-git-send-email-robert.dolca@intel.com> References: <1436541064-13381-1-git-send-email-robert.dolca@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 693 Lines: 27 On vr, 2015-07-10 at 18:11 +0300, Robert Dolca wrote: > +static struct i2c_driver silead_ts_driver = { > + [...] > + .driver = { > + [...] > +#ifdef CONFIG_ACPI > + .acpi_match_table = ACPI_PTR(silead_ts_acpi_match), > +#endif A nit: for the !CONFIG_ACPI case include/linux/acpi.h contains #define ACPI_PTR(_ptr) (NULL) So I think the above CONFIG_ACPI guard is superfluous and can be dropped. > +[...] > + }, > +}; Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/