Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750962AbbGKOT7 (ORCPT ); Sat, 11 Jul 2015 10:19:59 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34240 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbbGKOT5 (ORCPT ); Sat, 11 Jul 2015 10:19:57 -0400 Date: Sat, 11 Jul 2015 16:19:49 +0200 From: Frederic Weisbecker To: Chris Metcalf Cc: LKML , Peter Zijlstra , Thomas Gleixner , Don Zickus , Ulrich Obergfell , Andrew Morton Subject: Re: [PATCH 0/4] smpboot/watchdog: Fixes and cleanups Message-ID: <20150711141946.GD10257@lerouge> References: <1436454992-21462-1-git-send-email-fweisbec@gmail.com> <559EE09B.7090706@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559EE09B.7090706@ezchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 47 On Thu, Jul 09, 2015 at 04:59:07PM -0400, Chris Metcalf wrote: > On 07/09/2015 11:16 AM, Frederic Weisbecker wrote: > >Hi, > > > >The 2nd patch should fix the strange bug we've seen with Chris. > > > >git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git > > core/watchdog > > > >HEAD: 5e36d90b3ccb0023ad54ac7a2381c132c6b12280 > > > >Thanks, > > Frederic > >--- > > > >Frederic Weisbecker (4): > > smpboot: Fix memory leak on error handling > > smpboot: Make cleanup to mirror setup > > smpboot: Allow to pass the cpumask on per-cpu thread registration > > watchdog: Simplify housekeeping affinity with the appropriate mask > > > > > > include/linux/smpboot.h | 11 ++++++++++- > > kernel/smpboot.c | 22 +++++++++------------- > > kernel/watchdog.c | 15 +++++---------- > > 3 files changed, 24 insertions(+), 24 deletions(-) > > You can add my > > Reviewed-by: Chris Metcalf > > to all four. There are a couple of typos in the commit message for > patch 2/4: "ressources" and "lets simply" (should be "let's simply"). Ok I'm going to respin and ask Andrew to apply them. > Glad you figured out what the bug was. Curious that in your > environment you got a panic rather than an infinite loop waiting > for a timer subsystem pointer to go non-NULL. It might be a config difference. In my box it crashes because hrtimer_cancel() called on an htimer that hasn't been init does a NULL dereference of the cpu base. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/