Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbbGKOul (ORCPT ); Sat, 11 Jul 2015 10:50:41 -0400 Received: from forward1m.mail.yandex.net ([37.140.138.1]:60248 "EHLO forward1m.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbbGKOui (ORCPT ); Sat, 11 Jul 2015 10:50:38 -0400 X-Greylist: delayed 458 seconds by postgrey-1.27 at vger.kernel.org; Sat, 11 Jul 2015 10:50:37 EDT From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Vaishali Thakkar Cc: "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Rajat Jain In-Reply-To: <20150707065349.GA11853@vaishali-Ideapad-Z570> References: <20150707065349.GA11853@vaishali-Ideapad-Z570> Subject: Re: [PATCH] w1: Use module_pci_driver MIME-Version: 1.0 Message-Id: <4894201436625771@web27m.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sat, 11 Jul 2015 17:42:51 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 43 Hi everyone Patch looks good to me, thank you Greg, please pull it into your tree Acked-by: Evgeniy Polyakov 07.07.2015, 09:55, "Vaishali Thakkar" : > Use module_pci_driver for drivers whose init and exit functions > only register and unregister, respectively. > Signed-off-by: Vaishali Thakkar > --- > ?drivers/w1/masters/matrox_w1.c | 14 +------------- > ?1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c > index d8667b0..684bc9d 100644 > --- a/drivers/w1/masters/matrox_w1.c > +++ b/drivers/w1/masters/matrox_w1.c > @@ -232,16 +232,4 @@ static void matrox_w1_remove(struct pci_dev *pdev) > ?????????} > ?????????kfree(dev); > ?} > - > -static int __init matrox_w1_init(void) > -{ > - return pci_register_driver(&matrox_w1_pci_driver); > -} > - > -static void __exit matrox_w1_fini(void) > -{ > - pci_unregister_driver(&matrox_w1_pci_driver); > -} > - > -module_init(matrox_w1_init); > -module_exit(matrox_w1_fini); > +module_pci_driver(matrox_w1_pci_driver); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/