Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751545AbbGKP4t (ORCPT ); Sat, 11 Jul 2015 11:56:49 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:35845 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbbGKP4r (ORCPT ); Sat, 11 Jul 2015 11:56:47 -0400 Date: Sat, 11 Jul 2015 17:56:37 +0200 From: Ulf Magnusson To: Andreas Ruprecht Cc: Paul Bolle , Valentin Rothberg , rafael.j.wysocki@intel.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, hengelein Stefan , linux@dominikbrodowski.net, Michal Marek Subject: Re: [PATCH v3 0/2] kconfig: warn of unhandled characters in Kconfig commands Message-ID: <20150711155637.GA25144@huvuddator> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1666 Lines: 48 On Fri, Jul 10, 2015 at 10:25:31AM +0200, Andreas Ruprecht wrote: > This patchset changes the lexer file to emit a warning if any unhandled > characters are found in the input. So far, Kconfig options like > > +config FOO > bool > [...] > > (note the wrong '+'!) were parsed without a warning. As simply adding a > warning for '.' produces lots of warnings as occasionally '---help---' > is used instead of 'help' (and thus '-' is recognized as an unhandled > character), we need to handle '---help---' separately. > > Changes to v1: > - add '---help---' in zconf.gperf instead of special casing > it in zconf.l > > Changes to v2: > - Do no constify char parameter to warn_ignored_character > - Shorten rule definitions for '.' > > Andreas Ruprecht (2): > kconfig: warn of unhandled characters in Kconfig commands > kconfig: Regenerate shipped zconf.{hash,lex}.c files > > scripts/kconfig/zconf.gperf | 1 + > scripts/kconfig/zconf.hash.c_shipped | 58 ++++--- > scripts/kconfig/zconf.l | 20 ++- > scripts/kconfig/zconf.lex.c_shipped | 325 +++++++++++++++++------------------ > 4 files changed, 204 insertions(+), 200 deletions(-) > > -- > 1.9.1 > Looks good to me. I ran the Kconfiglib test suite on it too. Since it simply compares the output of Kconfiglib and the C implementation, it doubles as a good regression test for the C implementation. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/